Recent Topics widget settings won't save.

[jaredatch]

Reported here http://bbpress.org/forums/topic/recent-topics-widget-2/

Tested on trunk and was able to replicate the issue.

Parent Forum ID, Show post date, and Show topic author don't save correctly. I know this was working at some point so I'm not quite sure what happened.

[alex-ye]

Well, It's not Recent Topics widget only you can test the check-boxes in the Replies widget.

The patch below do this:
1- Fix the Parent Forum ID bug in the Topics widget.
2- Add a value for the check-box input, and and correct the use of checked() function.
3- Change the use of esc_url to esc_url_raw during the save.

[jaredatch]

I whipped up a patch this morning only to find out you beat me to it :)

Looks good to go for me.

[johnjamesjacoby]

In 4885:

Fix a few widget fields that were not saving correctly. Props alex-ye. Fixes #2319 (trunk)

[johnjamesjacoby]

In 4886:

Fix a few widget fields that were not saving correctly. Props alex-ye. Fixes #2319 (2.3 branch)

[netweb]

I can repro this with current 2.4 release build, also reported here.

[alex-ye]

@netweb can you test the above patch?

[netweb]

Replying to alex-ye:

@netweb can you test the above patch?

Done, looks good and works as expected, makes sense from the code I was looked at earlier.

[alex-ye]

Replying to netweb:

Replying to alex-ye:

@netweb can you test the above patch?

Done, looks good and works as expected, makes sense from the code I was looked at earlier.

Yeah. this is related to changest ​4995 too.

[johnjamesjacoby]

Duplicate #2436.

[johnjamesjacoby]

In 5111:

Use empty() instead of strict 'on' comparison in topics widget. Props alex-ye. Fixes #2319. (2.5)

[johnjamesjacoby]

In 5112:

Use empty() instead of strict 'on' comparison in topics widget. Props alex-ye. Fixes #2319. (2.4.1)