Skip to:
Content

bbPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#2319 closed defect (fixed)

Recent Topics widget settings won't save.

Reported by: jaredatch Owned by: johnjamesjacoby
Milestone: 2.4.1 Priority: normal
Severity: normal Version:
Component: API - Widgets Keywords: has-patch
Cc:

Description

Reported here http://bbpress.org/forums/topic/recent-topics-widget-2/

Tested on trunk and was able to replicate the issue.

Parent Forum ID, Show post date, and Show topic author don't save correctly. I know this was working at some point so I'm not quite sure what happened.

Attachments (2)

common-widgets.patch (5.2 KB) - added by alex-ye 6 years ago.
2319.patch (2.0 KB) - added by alex-ye 6 years ago.

Download all attachments as: .zip

Change History (14)

#1 @alex-ye
6 years ago

Well, It's not Recent Topics widget only you can test the check-boxes in the Replies widget.

The patch below do this:
1- Fix the Parent Forum ID bug in the Topics widget.
2- Add a value for the check-box input, and and correct the use of checked() function.
3- Change the use of esc_url to esc_url_raw during the save.

#2 @alex-ye
6 years ago

  • Keywords has-patch added; needs-patch removed

#3 @jaredatch
6 years ago

I whipped up a patch this morning only to find out you beat me to it :)

Looks good to go for me.

#4 @johnjamesjacoby
6 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 4885:

Fix a few widget fields that were not saving correctly. Props alex-ye. Fixes #2319 (trunk)

#5 @johnjamesjacoby
6 years ago

In 4886:

Fix a few widget fields that were not saving correctly. Props alex-ye. Fixes #2319 (2.3 branch)

#6 @netweb
6 years ago

  • Milestone changed from 2.3.2 to Awaiting Review
  • Resolution fixed deleted
  • Status changed from closed to reopened

I can repro this with current 2.4 release build, also reported here.

@alex-ye
6 years ago

#7 follow-up: @alex-ye
6 years ago

@netweb can you test the above patch?

#8 in reply to: ↑ 7 ; follow-up: @netweb
6 years ago

  • Milestone changed from Awaiting Review to 2.4.1

Replying to alex-ye:

@netweb can you test the above patch?

Done, looks good and works as expected, makes sense from the code I was looked at earlier.

#9 in reply to: ↑ 8 @alex-ye
6 years ago

Replying to netweb:

Replying to alex-ye:

@netweb can you test the above patch?

Done, looks good and works as expected, makes sense from the code I was looked at earlier.

Yeah. this is related to changest 4995 too.

#11 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5111:

Use empty() instead of strict 'on' comparison in topics widget. Props alex-ye. Fixes #2319. (2.5)

#12 @johnjamesjacoby
6 years ago

In 5112:

Use empty() instead of strict 'on' comparison in topics widget. Props alex-ye. Fixes #2319. (2.4.1)

Note: See TracTickets for help on using tickets.