Changeset 5111

Timestamp:

09/27/2013 07:04:47 PM (11 years ago)

Author:

johnjamesjacoby

Message:

Use empty() instead of strict 'on' comparison in topics widget. Props alex-ye. Fixes #2319. (2.5)

File:

• trunk/includes/common/widgets.php (modified) (5 diffs)

trunk/includes/common/widgets.php

@@ -804 +804 @@
 
                 // Maybe get the topic author
-                if ( 'on' === $settings['show_user'] ) :
+                if ( ! empty( $settings['show_user'] ) ) :
                     $author_link = bbp_get_topic_author_link( array( 'post_id' => $topic_id, 'type' => 'both', 'size' => 14 ) );
                 endif; ?>
@@ -817 +817 @@
                     <?php endif; ?>
 
-                    <?php if ( 'on' === $settings['show_date'] ) : ?>
+                    <?php if ( ! empty( $settings['show_date'] ) ) : ?>
 
                         <div><?php bbp_topic_last_active_time( $topic_id ); ?></div>
@@ -1155 +1155 @@
 
                     // Only query user if showing them
-                    if ( 'on' === $settings['show_user'] ) :
+                    if ( ! empty( $settings['show_user'] ) ) :
                         $author_link = bbp_get_reply_author_link( array( 'post_id' => $reply_id, 'type' => 'both', 'size' => 14 ) );
                     else :
@@ -1162 +1162 @@
 
                     // Reply author, link, and timestamp
-                    if ( ( 'on' === $settings['show_date'] ) && !empty( $author_link ) ) :
+                    if ( ! empty( $settings['show_date'] ) && !empty( $author_link ) ) :
 
                         // translators: 1: reply author, 2: reply link, 3: reply timestamp
@@ -1168 +1168 @@
 
                     // Reply link and timestamp
-                    elseif ( 'on' === $settings['show_date'] ) :
+                    elseif ( ! empty( $settings['show_date'] ) ) :
 
                         // translators: 1: reply link, 2: reply timestamp