Skip to:
Content

bbPress.org

Opened 12 years ago

Closed 12 years ago

#2318 closed defect (bug) (fixed)

Remove the_title_attribute() from anchors with the_title() as text

Reported by: alex-ye's profile alex-ye Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.3.1
Component: General Keywords: has-patch
Cc:

Change History (8)

#1 @johnjamesjacoby
12 years ago

  • Milestone changed from Awaiting Review to 2.4

Will do in 2.4. Should be a relatively straightforward patch if anyone wants an easy contribution.

#2 @johnjamesjacoby
12 years ago

  • Milestone changed from 2.4 to 2.5

No patch. Moving to 2.5.

#3 @johnjamesjacoby
12 years ago

  • Milestone changed from 2.5 to 2.4

Moving back to 2.4. Should be addressed asap, as it's already done in WordPress.

#4 @johnjamesjacoby
12 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 4948:

Audit title attributes, and remove instances where they would match template-tag contents. Fixes #2318.

#5 follow-ups: @alex-ye
12 years ago

  • Keywords has-patch added; needs-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Why you remove title attribute when the link text is an ID ?!

#6 in reply to: ↑ 5 ; follow-up: @alexvorn2
12 years ago

Replying to alex-ye:

Why you remove title attribute when the link text is an ID ?!

what do you mean?

#7 in reply to: ↑ 6 @alex-ye
12 years ago

Replying to alexvorn2:

Replying to alex-ye:

Why you remove title attribute when the link text is an ID ?!

what do you mean?

See this:

<a href="<?php bbp_topic_permalink(); ?>" class="bbp-topic-permalink">#<?php bbp_topic_id(); ?></a> 

It should have a title attribute, right?

#8 in reply to: ↑ 5 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to alex-ye:

Why you remove title attribute when the link text is an ID ?!

Consulted with a friend that uses Jaws.

Anecdotal, but he claims title tags don't provide much value, as he's able to understand what these links are for without one.

Closing as fixed.

Note: See TracTickets for help on using tickets.