Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

#2318 closed defect (bug) (fixed)

Remove the_title_attribute() from anchors with the_title() as text

Reported by: alex-ye Owned by: johnjamesjacoby
Priority: normal Milestone: 2.4
Component: General Version: 2.3.1
Severity: normal Keywords: has-patch
Cc:

Description

see: ​http://core.trac.wordpress.org/ticket/24203

Change History (8)

#1 @johnjamesjacoby
13 years ago

  • Milestone Awaiting Review → 2.4

Will do in 2.4. Should be a relatively straightforward patch if anyone wants an easy contribution.

#2 @johnjamesjacoby
13 years ago

  • Milestone 2.4 → 2.5

No patch. Moving to 2.5.

#3 @johnjamesjacoby
13 years ago

  • Milestone 2.5 → 2.4

Moving back to 2.4. Should be addressed asap, as it's already done in WordPress.

#4 @johnjamesjacoby
13 years ago

  • Owner set to johnjamesjacoby
  • Resolution → fixed
  • Status new → closed

In 4948:

Audit title attributes, and remove instances where they would match template-tag contents. Fixes #2318.

#5 follow-ups: @alex-ye
13 years ago

  • Keywords has-patch added; needs-patch removed
  • Resolution fixed
  • Status closed → reopened

Why you remove title attribute when the link text is an ID ?!

#6 in reply to: ↑ 5 ; follow-up: @alexvorn2
13 years ago

Replying to alex-ye:

Why you remove title attribute when the link text is an ID ?!

what do you mean?

#7 in reply to: ↑ 6 @alex-ye
13 years ago

Replying to alexvorn2:

Replying to alex-ye:

Why you remove title attribute when the link text is an ID ?!

what do you mean?

See this:

<a href="<?php bbp_topic_permalink(); ?>" class="bbp-topic-permalink">#<?php bbp_topic_id(); ?></a>

It should have a title attribute, right?

#8 in reply to: ↑ 5 @johnjamesjacoby
13 years ago

  • Resolution → fixed
  • Status reopened → closed

Replying to alex-ye:

Why you remove title attribute when the link text is an ID ?!

Consulted with a friend that uses Jaws.

Anecdotal, but he claims title tags don't provide much value, as he's able to understand what these links are for without one.

Closing as fixed.

Note: See TracTickets for help on using tickets.