Ticket #2319: 2319.patch

includes/common/widgets.php

@@ -803 +803 @@
                                 $author_link = '';
 
                                 // Maybe get the topic author
-                                if ( 'on' === $settings['show_user'] ) :
+                                if ( $settings['show_user'] ) :
                                         $author_link = bbp_get_topic_author_link( array( 'post_id' => $topic_id, 'type' => 'both', 'size' => 14 ) );
                                 endif; ?>
 
@@ -816 +816 @@
 
                                         <?php endif; ?>
 
-                                        <?php if ( 'on' === $settings['show_date'] ) : ?>
+                                        <?php if ( $settings['show_date'] ) : ?>
 
                                                 <div><?php bbp_topic_last_active_time( $topic_id ); ?></div>
 
@@ -1154 +1154 @@
                                         $reply_link = '<a class="bbp-reply-topic-title" href="' . esc_url( bbp_get_reply_url( $reply_id ) ) . '" title="' . esc_attr( bbp_get_reply_excerpt( $reply_id, 50 ) ) . '">' . bbp_get_reply_topic_title( $reply_id ) . '</a>';
 
                                         // Only query user if showing them
-                                        if ( 'on' === $settings['show_user'] ) :
+                                        if ( $settings['show_user'] ) :
                                                 $author_link = bbp_get_reply_author_link( array( 'post_id' => $reply_id, 'type' => 'both', 'size' => 14 ) );
                                         else :
                                                 $author_link = false;
                                         endif;
 
                                         // Reply author, link, and timestamp
-                                        if ( ( 'on' === $settings['show_date'] ) && !empty( $author_link ) ) :
+                                        if ( $settings['show_date'] && !empty( $author_link ) ) :
 
                                                 // translators: 1: reply author, 2: reply link, 3: reply timestamp
                                                 printf( _x( '%1$s on %2$s %3$s', 'widgets', 'bbpress' ), $author_link, $reply_link, '<div>' . bbp_get_time_since( get_the_time( 'U' ) ) . '</div>' );
 
                                         // Reply link and timestamp
-                                        elseif ( 'on' === $settings['show_date'] ) :
+                                        elseif ( $settings['show_date'] ) :
 
                                                 // translators: 1: reply link, 2: reply timestamp
                                                 printf( _x( '%1$s %2$s',         'widgets', 'bbpress' ), $reply_link,  '<div>' . bbp_get_time_since( get_the_time( 'U' ) ) . '</div>'              );