Skip to:
Content

bbPress.org

Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#496 closed enhancement (fixed)

convert Support/Resolved/Not Resolved a features into a plugin

Reported by: so1o's profile so1o Owned by: so1o's profile so1o
Milestone: 0.8 Priority: normal
Severity: normal Version: 0.7.3
Component: General - Administration Keywords: has-patch
Cc:

Description

http://bbpress.org/forums/topic/362

if the site is a forum just for discussion and is not a support forum, these options are redundant.

Attachments (4)

ticket-496.patch (1.9 KB) - added by so1o 19 years ago.
Patch to implement config based support forum
ticket-496.2.patch (8.2 KB) - added by so1o 19 years ago.
patch to remove all references to resolve/not resolved
support-forum.php (7.7 KB) - added by so1o 19 years ago.
Support Forum Plugin
496.diff (1.8 KB) - added by mdawaffe 19 years ago.

Download all attachments as: .zip

Change History (23)

#1 @so1o
19 years ago

references:

  • bb-templates\topic.php
    • <?php topic_resolved(); ?> this will have to be displayed after checking for options
  • bb-includes\function.php
    • get_views() - this can be fixed by filter applied or processing after checking the options

#2 @so1o
19 years ago

  • Owner set to so1o
  • Status changed from new to assigned

@so1o
19 years ago

Patch to implement config based support forum

#3 @so1o
19 years ago

Attached the patch to implement the following

  • add a option in the config file
  • if the config is set to true show the resolution drop down in the topic template
  • if the config is set to true add view unresolved topic option

#4 @mdawaffe
19 years ago

I think for .80 we should just scrap the support forum stuff entirely and make it a plugin.

#5 @mdawaffe
19 years ago

Let's be sure to incorporate #504 into the future plugin.

#6 @so1o
19 years ago

if we are removing this , should we keep the topic_resolved column in the topic table?

we can keep it and use it in the plugin..

any thoughts?

#7 @mdawaffe
19 years ago

  • Milestone changed from 1.0 to 0.80

I was going to suggest using topic_meta to store that info. Queries will be a bit slower if we do that, though.

@so1o
19 years ago

patch to remove all references to resolve/not resolved

#8 @so1o
19 years ago

  • Keywords has-patch added
  • Summary changed from Make the Support/Resolved/Not Resolved a feature selectable from site options to convert Support/Resolved/Not Resolved a features into a plugin

Patch added to remove all references to resolved and not resolved.

i have created a plugin with all (ALL) functionality that was in there. i will post it here soon.

besides the patch, the upgrade script will need to be updated to remove the topic_resolved column

@so1o
19 years ago

Support Forum Plugin

#9 @so1o
19 years ago

The support forum plugin is attached. Later we might add functionality to the plugin to add custom options.

#10 @mdawaffe
19 years ago

(In [581]) axe resolution status. Relegate to plugin. re #496 props so1o

#11 @mdawaffe
19 years ago

Verp nice catch, so1o :)

I'll work on the upgrade script. I think we should convert topic.topic_resolved into topicmeta "topic_resolved" to be more transparent to themes and other plugins that may already look at $topic->topic_resolved.

That as opposed to converting it to topicmeta "support_forum_resolved" as your plugin suggests.

Thoughts?

#12 @so1o
19 years ago

yup i agree..

#13 @so1o
19 years ago

question.. how does the system behave if i have a column named x and i add a metadata named x.. which shows up in the final output?

#14 @mdawaffe
19 years ago

The metadata will show up in the final output. (Oh the power!)

@mdawaffe
19 years ago

#15 @mdawaffe
19 years ago

so1o, can you look over 496.diff and let me know what you think?

#16 @so1o
19 years ago

line 281

bb_bb_update_topicmeta( $topic->topic_id, 'topic_resolved', $topic->topic_resolved );

should be

bb_update_topicmeta( $topic->topic_id, 'topic_resolved', $topic->topic_resolved ); 

shouldnt it?

#17 @mdawaffe
19 years ago

Well, I suppose so :)

#18 @mdawaffe
19 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [640]) upgrade script for topic_resolved. Fixes #496

#19 @mdawaffe
19 years ago

(In [695]) Better topic resolved upgrade script. Fixes #496

Note: See TracTickets for help on using tickets.