Skip to:
Content

Opened 7 years ago

Closed 7 years ago

#495 closed enhancement (fixed)

make bb_new_user() pluggable

Reported by: so1o Owned by: so1o
Milestone: 0.8 Priority: high
Severity: normal Version: 0.7.3
Component: Administration Keywords: has-patch
Cc:

Description

the new user creation process is currently very rigid and cannot be overridden without making changes to the core files.

Attachments (1)

ticket-495.patch (3.3 KB) - added by so1o 7 years ago.
pluggable bb_new_user and change to return user_id always

Download all attachments as: .zip

Change History (12)

comment:2 mdawaffe7 years ago

  • Milestone set to 0.80

comment:3 mdawaffe7 years ago

  • Priority changed from normal to high

comment:4 so1o7 years ago

  • Owner set to so1o
  • Status changed from new to assigned

comment:5 so1o7 years ago

any other ideas guys.. im running out of steam here..

comment:6 so1o7 years ago

  • Keywords has-patch added

comment:7 mdawaffe7 years ago

I would probably just put bb_create_user() in bb-includes/pluggable.php so that it can be replaced by a plugin rather than using a filter to accomplish that. We only need it to be replaced by one function, we don't need the ability to hook many functions onto the filter.

Also, does bb_new_user() ever need to return both the user_id and the password? I'd rather it only returned the user_id even when BB_INSTALLING. We can rewrite the install script to take advantage of the bb_new_user hook to grab the password.

comment:8 so1o7 years ago

if we put it in pluggable.. nope we wouldnt need to return the username and pass

so1o7 years ago

pluggable bb_new_user and change to return user_id always

comment:9 so1o7 years ago

how does this look..

comment:10 mdawaffe7 years ago

Looks great!

comment:11 mdawaffe7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [638]) pluggable bb_create_user() from so1o. Fixes #495.

Note: See TracTickets for help on using tickets.