Skip to:
Content

bbPress.org

Opened 2 months ago

Last modified 3 weeks ago

#3410 new defect

Topics held in moderation are not checked with Akismet

Reported by: procifer Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Extend - Akismet Keywords:
Cc:

Description

When a Topic triggers moderation or otherwise ends up in a state other than published, it is not sent to Akismet for spam checking.

For example, if the Hold a comment in the queue if it contains X or more links. setting is triggered by a very spammy Topic with many links, it is never sent to Akismet. It's put in the moderation queue for the site owner to review instead of winding up in Spam.

Seems like this is what’s causing it: https://bbpress.trac.wordpress.org/browser/trunk/src/includes/extend/akismet.php#L93
Since the Topics come in as “pending”, it doesn’t make it past that to the Akismet check.

Appears that behavior has been around since the first version, so not sure if it's intentional or not:
https://bbpress.trac.wordpress.org/browser/branches/plugin/bbp-includes/bbp-core-akismet.php?rev=3278

In Slack discussion with @johnjamesjacoby, it might be better to only check for certain statuses, excluding others (trashed, etc.). From an Akismet perspective, we're happy to check anything and everything, unless there's a scenario within bbPress usage where that doesn't make sense.

Otherwise the easiest solution may be to simply remove lines 93-95.

Change History (2)

#1 follow-up: @douglsmith
6 weeks ago

Would it help Akismet's learning to get everything regardless of status?

#2 in reply to: ↑ 1 @procifer
3 weeks ago

Replying to douglsmith:

Would it help Akismet's learning to get everything regardless of status?

Yes, that's a good point as well; with more spammy examples from a given site, accuracy would likely improve as well.

Note: See TracTickets for help on using tickets.