Skip to:
Content

bbPress.org

Opened 11 months ago

Closed 6 months ago

Last modified 6 months ago

#3410 closed defect (fixed)

Topics held in moderation are not checked with Akismet

Reported by: procifer Owned by: johnjamesjacoby
Milestone: 2.6.7 Priority: normal
Severity: normal Version:
Component: Extend - Akismet Keywords: needs-patch
Cc:

Description

When a Topic triggers moderation or otherwise ends up in a state other than published, it is not sent to Akismet for spam checking.

For example, if the Hold a comment in the queue if it contains X or more links. setting is triggered by a very spammy Topic with many links, it is never sent to Akismet. It's put in the moderation queue for the site owner to review instead of winding up in Spam.

Seems like this is what’s causing it: https://bbpress.trac.wordpress.org/browser/trunk/src/includes/extend/akismet.php#L93
Since the Topics come in as “pending”, it doesn’t make it past that to the Akismet check.

Appears that behavior has been around since the first version, so not sure if it's intentional or not:
https://bbpress.trac.wordpress.org/browser/branches/plugin/bbp-includes/bbp-core-akismet.php?rev=3278

In Slack discussion with @johnjamesjacoby, it might be better to only check for certain statuses, excluding others (trashed, etc.). From an Akismet perspective, we're happy to check anything and everything, unless there's a scenario within bbPress usage where that doesn't make sense.

Otherwise the easiest solution may be to simply remove lines 93-95.

Change History (8)

#1 follow-up: @douglsmith
10 months ago

Would it help Akismet's learning to get everything regardless of status?

#2 in reply to: ↑ 1 @procifer
9 months ago

Replying to douglsmith:

Would it help Akismet's learning to get everything regardless of status?

Yes, that's a good point as well; with more spammy examples from a given site, accuracy would likely improve as well.

This ticket was mentioned in Slack in #bbpress by procifer. View the logs.


6 months ago

#4 @johnjamesjacoby
6 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.6.7
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

#5 @johnjamesjacoby
6 months ago

In 7193:

Akismet: Remove "publish" status restriction in check_post().

This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.

Also fixes a typo and an incorrectly typed return value.

Props procifer, douglsmith.

In trunk for 2.7.0. See #3410.

#6 @johnjamesjacoby
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7194:

Akismet: Remove "publish" status restriction in check_post().

This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.

Also fixes a typo and an incorrectly typed return value.

Props procifer, douglsmith.

In branches/2.6 for 2.6.7. Fixes #3410.

#7 @johnjamesjacoby
6 months ago

In 7195:

Akismet: port SSL support from Akismet plugin.

This commit ensures that installations using SSL will send remote requests to https:// instead of http:// including retries and graceful degradation to http:// if necessary.

It also cleans up some related header & response logic to make it easier to understand.

In branches/2.6 for 2.6.7. See #3410.

#8 @johnjamesjacoby
6 months ago

In 7196:

Akismet: port SSL support from Akismet plugin.

This commit ensures that installations using SSL will send remote requests to https:// instead of http:// including retries and graceful degradation to http:// if necessary.

It also cleans up some related header & response logic to make it easier to understand.

In trunk for 2.7.0. See #3410.

Note: See TracTickets for help on using tickets.