Some reply context options are unavailable when topic is marked as spam

[Clorith]

If you mark a topic as spam, it may have legitimate replies, and spam replies mixed in under it.

Currently, if you mark a topic as spam, the context of the replies is switched. in base bbPress, they are all trashed instantly, and you then need to restore the reply, to then be able to mark it as spam.

To be able to effectively tackle a spam-topic with replies, you therefore need to start by marking any replies as spam, and then mark the topic as spam, which is a backwards route to take.

Would it make sense to still include the spam action on trashed replies?

[johnjamesjacoby]

Spam action on Trashed replies in 2.6

[johnjamesjacoby]

Hey @Clorith 👋

bbPress inherited some of this behavior from bbPress 1.x, because transitioning between statuses is tricky, especially with hierarchical or linked data (topics, replies, hierarchical replies, etc...)

Over the years of bbPress 2.x, we've tried to identify and introduce more support for more transitions, and I am pretty sure we have this exact case covered, but I also could be misunderstanding. I've attached a screen shot that shows the row-actions that I'm thinking that you're thinking about. 😁

[Clorith]

Sorry, completely missed your reply here.

I'm referring to the front-end actions shown under each post when looking at a topic, since you'd ideally not want any moderators to be tied to the back-end.

This appears to be caused by bbp_get_reply_admin_links(), specifically ​https://bbpress.trac.wordpress.org/browser/trunk/src/includes/replies/template.php#L1799 which explicitly removes the trash and spam options if the topic it self is marked as spam.

[johnjamesjacoby]

I see what you mean!

This should be pretty simple to accomplish.

### Summary

Allows moderators to mark trashed replies as spam from the front end by making the "Spam" action available on trashed replies. Previously, the "Spam" link was hidden for trashed replies, requiring them to be restored before marking as spam.

Changes:

• Removes the logic that hid the "Spam" link for trashed replies in bbp_get_reply_admin_links()
• The "Trash" link remains hidden for spam replies as before

bbPress Trac ​#3411