Issue with _bbp_pre_trashed_replies

[dungdc40]

File: includes\replies\functions.php
Line: 293
$pre_trashed_replies = (array) get_post_meta( $topic_id, '_bbp_pre_trashed_replies', true );

This line has issue, if get_post_meta() return empty string, then (array) will convert it to
array(1) {

[0]=>
string(0) ""

}
which add empty id into the array, which made the topic become not able to be unhidden later.

[johnjamesjacoby]

Fix for trash and spam

[johnjamesjacoby]

In 7140:

Replies: prevent adding empty values to pre-spam & pre-trash meta data.

This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.

In branches/2.6, for 2.6.6. See #3409.

[johnjamesjacoby]

In 7142:

Replies: prevent adding empty values to pre-spam & pre-trash meta data.

This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.

In trunk, for 2.7. Fixes #3409.