return WP_Error object when a reply, topic or forum

[tharsheblows]

The error message is used in the template notice. It'd actually be nice to filter these too but I haven't done that. What do you think?

Thinking about it, not sure this is good to add because it's going to change people's error notices, hmm.

[tharsheblows]

return WP_Error object on reply / topic / forum failure

[netweb]

Thanks @tharsheblows, take a look the ticket and comments on both #2116 and #1883

I'm leaning towards closing this as a duplicate of #1883 and/or wontfix based on #2116

[tharsheblows]

Ah yes, I see what they're saying about the filters. But the wp_insert_post needs to pass true to $wp_error or the error message needs to be changed as it's currently always:
The following problem(s) have been found with your reply:Please try again.

[tharsheblows]

change which wp_insert_post returns WP Error object in replies/functions.php

[tharsheblows]

I put it in the wrong wp_insert_post in replies/functions.php, argh. This one expects the WP Error object to be returned on failure, the other one doesn't.

Oops, editing to include code to show where it's expecting it, eg in forums/functions.phpL340

// Errors
	} else {
		$append_error = ( is_wp_error( $forum_id ) && $forum_id->get_error_message() ) ? $forum_id->get_error_message() . ' ' : '';
		bbp_add_error( 'bbp_forum_error', __( '<strong>ERROR</strong>: The following problem(s) have been found with your forum:' . $append_error, 'bbpress' ) );
	}

[thebrandonallen]

@netweb What do you want to do here?

[johnjamesjacoby]

We can do this, but we may end up pulling it later if we want to own the error messaging & verbiage to be more forum/public specific.

Moving to 2.6.

[johnjamesjacoby]

In 6499:

General: Audit wp_insert_post() usages.

Return a WP_Error object in some instances, and explicitly do not in others.

Where possible, use the error message in the user feedback response.

Fixes #2817.