Smarter template notices

[alexvorn2]

Currently, the themes include several hardcoded template notices at the top of various forms and pages. Ideally, these should fall under one dedicated action or template tag, with a loose convention on how to add/remove/modify notices.

This has the positive side-effect of eliminating duplicate code, and strings in the template files themselves. For example, when searching for "account has the ability to post unrestricted HTML" - six results are displayed. This means changing it in 6 different places instead of only once in a function.

[johnjamesjacoby]

Modified ticket title and description. Valid, but needed a little more meat.

[alexvorn2]

cool! :)

[johnjamesjacoby]

No time in 2.2; moving back to Future Release.

[netweb]

Whilst we are at it.... Adding 'context' to the notices.

eg. "You must be logged in to create new topics."

"You must be logged in to create new topics. Click here to login."

[gawain]

In relation to the bug #2116 I opened today, I'd be interested in having a go at this.

How does something like this look:

<?php bbp_tag_topic_cannot_reply() ?>

function bbp_tag_topic_cannot_reply()
{
    return apply_filters( 'bbp_tag_topic_cannot_reply', _e( 'You cannot create new topics.', bbpress ) );
}

[johnjamesjacoby]

Punting to 2.4.

[gawain]

Based on your comment in #2116, I presume you'd be happier with something like this then, jjj?

<?php bbp_topic_tag_cannot_reply() ?>

function bbp_topic_tag_cannot_reply()
{
    return _e( 'You cannot create new topics.', bbpress );
}

[johnjamesjacoby]

Replying to gawain:

Based on your comment in #2116, I presume you'd be happier with something like this then, jjj?

<?php bbp_topic_tag_cannot_reply() ?>

function bbp_topic_tag_cannot_reply()
{
    return _e( 'You cannot create new topics.', bbpress );
}

I really like keeping these in the theme. It makes it super easy to modify, and sets an easy convention plugins to introduce new messages.

Moving to 2.5 to keep thinking about this.

[johnjamesjacoby]

2.5 is going to focus on performance improvements. Moving to 2.6.

[johnjamesjacoby]

Bump to 2.7.

[johnjamesjacoby]

Bumping all 2.7 to 2.8 milestone.