Skip to:
Content

bbPress.org

Opened 4 years ago

Last modified 4 years ago

#2818 new enhancement

Redirect bbPress profile links to forum section of BuddyPress member profile

Reported by: sooskriszta Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Extend - BuddyPress Keywords: has-patch needs-testing
Cc: pericam@…, vivek@…

Description

Based on https://buddypress.trac.wordpress.org/ticket/4357

When BuddyPress AND bbPress are both installed, bbPress redirects profile from domain.com/forums/users/USERNAME/ to: domain.com/members/USERNAME/

The redirect should actually go to domain.com/members/USERNAME/forums/

Attachments (2)

bbpress-add-link.patch (6.2 KB) - added by axelskynet 4 years ago.
File members.php , string 115
bbpress-add-link.2.patch (6.2 KB) - added by axelskynet 4 years ago.
This is an updated patch file

Download all attachments as: .zip

Change History (16)

#1 @netweb
4 years ago

  • Milestone changed from Awaiting Review to 2.7

The relevant information from the Slack discussion in #buddypress here

jjj
Ha
bbPress profiles shouldn’t really exist when BuddyPress is active.
They should always redirect.


oc2ps
@jjj: i think they do redirect. at the moment to BP profile default tab. question is should it redirect to BP forums tab?


jjj
OIC
Probably? :simple_smile:
Put a ticket on the bbPress trac; we can look at it for 2.7.

#3 @Robkk
4 years ago

I disagree with this, how it works by default is fine enough.

If you want to change the default tab that is displayed when you are redirected to the users profile.

Add this to your wp-config.php file if you want the default tab to be forums

define( 'BP_DEFAULT_COMPONENT', 'forums' );

or maybe better just the users profile information.

define( 'BP_DEFAULT_COMPONENT', 'profile' );

I got the information from here.

https://codex.buddypress.org/getting-started/customizing/changing-internal-configuration-settings/

#4 follow-up: @espellcaste
4 years ago

@Robkk

I understand that we have more control with BuddyPress, but I believe this ticket is more about redirecting profile url when BuddyPress is activated and not about the default profile tab. I might be wrong, but currently, the ticket suggestion makes sense to me.

If BuddyPress is not activated, bbPress user profile goes to: domain.com/forums/users/USERNAME/
If BuddyPress is activated together with bbPress, makes sense the bbPress user profile redirect to: domain.com/members/USERNAME/forums/

In BuddyPress, you'll be able to change the default component regardless of the current change here.

Last edited 4 years ago by espellcaste (previous) (diff)

#5 @netweb
4 years ago

  • Summary changed from Merge BuddyPress & bbPress user profiles to Redirect bbPress profile links to forum section of BuddyPress member profile

At the moment when bbPress is activated on a site with BuddyPress activated and you click on a users username/profile link bbPress makes this link to the BuddyPress member profile just as BuddyPress does for all of its own components, groups, activity etc

Example:

Component Destination after clicking a username
Groups https://example.com/members/USERNAME/
Activityhttps://example.com/members/USERNAME/
bbPresshttps://example.com/members/USERNAME/

Now this proposal in this ticket wants to change that to:

Component Destination after clicking a username
bbPresshttps://example.com/members/USERNAME/forums

Is there also a ticket and proposal to update the BP components to:

Component Destination after clicking a username
Groups https://example.com/members/USERNAME/groups
Activityhttps://example.com/members/USERNAME/activity

The way I see it is when I click on a users username/profile link I'm expecting to go to the users profile page, not a sub-section of their profile.

Based on the above and for consistency unless BuddyPress is also planning on changing the destination links based on context then I'm suggesting this ticket be closed as wontfix.

#6 @Stagger Lee
4 years ago

  • Cc pericam@… added

#7 in reply to: ↑ 4 ; follow-up: @sooskriszta
4 years ago

  • Cc vivek@… added

Replying to espellcaste:

If BuddyPress is not activated, bbPress user profile goes to: domain.com/forums/users/USERNAME/
If BuddyPress is activated together with bbPress, makes sense the bbPress user profile redirect to: domain.com/members/USERNAME/forums/

That's exactly what this ticket is.

The reason is simple. When folks click on username in forums, they expect to see "forum profile" - topics created, replies created, latest activity in forums, etc....basically the stuff you would see if you clicked username/photo in phpBB, vBulletin, etc. In BuddyPress this information is on the Forums tab. So there.

#8 in reply to: ↑ 7 @netweb
4 years ago

Replying to sooskriszta:

The reason is simple. When folks click on username in forums, they expect to see "forum profile" - topics created, replies created, latest activity in forums, etc....basically the stuff you would see if you clicked username/photo in phpBB, vBulletin, etc. In BuddyPress this information is on the Forums tab. So there.

To extend your analogy, if I click on a username in BP's activity stream I should expect to see the users "activity profile" - all the users BuddyPress activity items e.g. https://example.com/members/USERNAME/activity ?

I see consistency as an issue here, if we're going to link to specific components or sections of a user profile then this should be consistent across all components and not just forums, so activity and groups should do the same.

#9 @sooskriszta
4 years ago

Consistency is not the be-all and end-all of UI. Usability and user experience do dictate that we give users (mostly) what they are used to and therefore expect. They expect what 80-90% of the web does already.

Practically every forum on the web works this way - clicking on username or photo leads to forum activity details.

Social networks also work somewhat similarly - from your Facebook wall if you click on username or photo of a friend, you are taken to their "activity" tab or "wall". In BuddyPress it doesn't matter right now because "user profile" default page is really an "activity" page.

Either way, the consistency issue should be discussed within BuddyPress forums and Trac. Here at bbPress, we should be consistent with the rest of the world, and leave BuddyPress consistency to BuddyPress.

Last edited 4 years ago by sooskriszta (previous) (diff)

#10 @espellcaste
4 years ago

I'm inclined to agree and at the same time disagree.

Maybe a lot of us use BuddyPress with bbPress together, as I'm using in my community, but even in my situation, @sooskriszta suggestion seems more appropriate.

For example, right now, I've used the define( 'BP_DEFAULT_COMPONENT', 'forums' ); to allow the default BuddyPress tab on the forums. Because in my community, the focus lies more on the forum part rather on the activity.

But I can see there are so many possible use cases and combinations that it'd be hard to align both. So in this case, again, @sooskriszta suggestion seems more appropriate as it seems to be case in other forums around the internet.

@axelskynet
4 years ago

File members.php , string 115

#11 @axelskynet
4 years ago

Patch provides redirect from "domain.com/members/USERNAME/" to "domain.com/members/USERNAME/forums/"

#12 follow-up: @sooskriszta
4 years ago

Patch doesn't seem to change any code.

@axelskynet
4 years ago

This is an updated patch file

#13 in reply to: ↑ 12 @axelskynet
4 years ago

Replying to sooskriszta:

Patch doesn't seem to change any code.

File members.php , string 115 , add string ".'forums/'" to end.

#14 @sooskriszta
4 years ago

  • Keywords has-patch needs-testing added
Note: See TracTickets for help on using tickets.