bbp_is_deactivation() break the bbPress!

[alex-ye]

When you pass the below GET query in any bbPress page in the front-end:

?action=deactivate&plugin=bbpress/bbpress.php

The page will borken, I don't know if this have a side effects or causing some another bugs, but this bug should be fixed!

In another topic, I am wondering if bbp_is_deactivation() still important.
What is the main purpose for it now ?!

[johnjamesjacoby]

Interesting. Moving to 2.4 to fix this right away.

These functions exist to execute or prevent code execution if bbPress is in the process of being activated or deactivated.

[johnjamesjacoby]

In 5076:

Add is_admin() and $pagenow checks to bbp_is_deactivation() and bbp_is_activation(). Hat tip alex-ye. Fixes #2386.

[alex-ye]

Replying to johnjamesjacoby:

These functions exist to execute or prevent code execution if bbPress is in the process of being activated or deactivated.

I see that, but what this worth?! What if the bbPress code executed in the process of being deactivated, What the bugs will be thrown?

Sorry for the many questions, This is the first time I see this thing in a WordPress plugin and I want to know more about it :)