Give some love to the RTL style!

[alex-ye]

Currently bbPress have both styles for LTR and RTL languages, bbpress.css and bbpress-rtl.css but the bbpress-rtl.css is just a full copy of bbpress.css with some confections.

What that means?
Generally WordPress themes have the both style.css and rtl.css the second file loaded (in addition) only when the RTL languages in use, unlike bbPress if you want to change an element colour you should modify the bbpress.css and bbpress-rtl.css !

This is confusing and make the developing really hard for both theme developers and core developers!

[alex-ye]

0.1

[alex-ye]

I have uploaded a new version of bbpress-rtl.css which contents the RTL styles ony, we will need to update bbpress-functions.php to load the both bbpress.css and bbpress-rtl.css at the same time.

PLEASE TEST IT :)

[johnjamesjacoby]

Worth testing early in 2.5. Thanks for the patch!

[johnjamesjacoby]

Moving to 2.5 milestone to test and highlight in the 2.5 release.

[mordauk]

It's super garbled on the front end.

Updated version: ​http://screencloud.net/v/xwtL
Current version: ​http://screencloud.net/v/os81

[alex-ye]

@mordauk You should change your theme to load the both files bbpress.css and bbpress-rtl.css at the same time, you will find the code in bbpress-functions.php .

[alex-ye]

If someone have time to upload a patch for bbpress-functions.php , just do it :)

[netweb]

@alex-ye Can you check the current patches and if needed refresh them?

[alex-ye]

Replying to netweb:

@alex-ye Can you check the current patches and if needed refresh them?

Sure thing, I will check it today :)

[alex-ye]

@netweb Go for it :)

[netweb]

Unified patch

[johnjamesjacoby]

Looks great. Love the red. :)

[netweb]

In ​2385-unified.1.diff refreshed patch with latest CSS changes.

[johnjamesjacoby]

In 5166:

RTLove. Props netweb, alex-ye. Fixes #2385.