Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

#2385 closed enhancement (fixed)

Give some love to the RTL style!

Reported by: alex-ye Owned by: johnjamesjacoby
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3.2
Component: Appearance - Theme Compatibility Keywords: has-patch early
Cc: pippin@…, stephen@…, mercijavier@…

Description

Currently bbPress have both styles for LTR and RTL languages, bbpress.css and bbpress-rtl.css but the bbpress-rtl.css is just a full copy of bbpress.css with some confections.

What that means?
Generally WordPress themes have the both style.css and rtl.css the second file loaded (in addition) only when the RTL languages in use, unlike bbPress if you want to change an element colour you should modify the bbpress.css and bbpress-rtl.css !

This is confusing and make the developing really hard for both theme developers and core developers!

Attachments (4)

bbpress-rtl-trunk.css (8.5 KB) - added by alex-ye 8 years ago.
0.1
bbpress-functions.php.patch (2.1 KB) - added by alex-ye 8 years ago.
2385-unified.diff (36.3 KB) - added by netweb 8 years ago.
Unified patch
2385-unified.1.diff (38.2 KB) - added by netweb 8 years ago.

Download all attachments as: .zip

Change History (18)

@alex-ye
8 years ago

0.1

#1 @alex-ye
8 years ago

I have uploaded a new version of bbpress-rtl.css which contents the RTL styles ony, we will need to update bbpress-functions.php to load the both bbpress.css and bbpress-rtl.css at the same time.

PLEASE TEST IT :)

#2 @johnjamesjacoby
8 years ago

  • Keywords early added
  • Milestone changed from Awaiting Review to 2.5

Worth testing early in 2.5. Thanks for the patch!

#3 @johnjamesjacoby
8 years ago

  • Keywords needs-testing added

Moving to 2.5 milestone to test and highlight in the 2.5 release.

#4 @mordauk
8 years ago

  • Cc pippin@… added
  • Keywords changed from has-patch, early, needs-testing to has-patch early, needs-testing

It's super garbled on the front end.

Updated version: http://screencloud.net/v/xwtL
Current version: http://screencloud.net/v/os81

#5 @netweb
8 years ago

  • Cc stephen@… added
  • Keywords changed from has-patch early, needs-testing to has-patch early needs-testing

#6 @alex-ye
8 years ago

@mordauk You should change your theme to load the both files bbpress.css and bbpress-rtl.css at the same time, you will find the code in bbpress-functions.php .

#7 @alex-ye
8 years ago

If someone have time to upload a patch for bbpress-functions.php , just do it :)

#8 @mercime
8 years ago

  • Cc mercijavier@… added

#9 follow-up: @netweb
8 years ago

  • Keywords needs-refresh added

@alex-ye Can you check the current patches and if needed refresh them?

#10 in reply to: ↑ 9 @alex-ye
8 years ago

Replying to netweb:

@alex-ye Can you check the current patches and if needed refresh them?

Sure thing, I will check it today :)

#11 @alex-ye
8 years ago

  • Keywords needs-testing needs-refresh removed

@netweb Go for it :)

@netweb
8 years ago

Unified patch

#12 @johnjamesjacoby
8 years ago

Looks great. Love the red. :)

#13 @netweb
8 years ago

In 2385-unified.1.diff refreshed patch with latest CSS changes.

Last edited 8 years ago by netweb (previous) (diff)

#14 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5166:

RTLove. Props netweb, alex-ye. Fixes #2385.

Note: See TracTickets for help on using tickets.