Opened 4 months ago
Last modified 4 months ago
#3613 new regression
PHPCS Resurrection + WordPress.PHP.YodaConditions Sorted
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | highest omg sweet tea |
Severity: | normal | Version: | trunk |
Component: | Tools - Build | Keywords: | has-patch |
Cc: |
Description
The thing is that executing a lint via phpcs
with phpcs.xml.dist
was throwing a high number of errors.
So basically, I've cleaned up the file, reorganized all the excluded modules, removed the conflicting ones, modified some composer.json
packages to update to the latest versions, and then it started throwing some information.
From there, I've chosen one exclusion at random, in this case WordPress.PHP.YodaConditions
and I've sorted all the notices all over the plugin to have this satisfied.
I've tripled checked everything but still, one extra eye is never too much
I'm expecting to keep sorting at least all WordPress.*
conditions in the near future, so it would be great to have this integrated in trunk as soon as possible (because it will be a pain having to extract and integrate patches from trunk without this basic requirements sorted, and having to be applied by myself every trunk fresh pull). Likewise, I'm prioritizing this because I don't really know the WordPress Code Standards and I need some code linting by default, so I'm adding special priority.
Patch with PHPCS Dist file resurrection + All the YodaConditions Sorted