PHPCS sorting: WordPress.WhiteSpace and WP.PostsPerPage

[SirLouen]

This is the #2 part of a series of PHPCS WPCS sorting

Starting the series here:
​https://bbpress.trac.wordpress.org/ticket/3613

I'm including in this issue sorting for:

WordPress.WP.I18n.NonSingularStringLiteralText
WordPress.WP.PostsPerPage.posts_per_page_posts_per_page
WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceAfterOpenParenthesis
WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceBeforeCloseParenthesis
WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterOpenParenthesis
WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeCloseParenthesis
WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter
WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore
WordPress.WhiteSpace.OperatorSpacing.SpacingAfter
WordPress.WhiteSpace.OperatorSpacing.SpacingBefore

I want to divide this into different issues because dozens of files are getting involved. This way it will be easier to keep it short for a code review and more frequent releases for the committer than having all the full CS review just in one massive commit.

This is an incremental update of #23
​https://bbpress.trac.wordpress.org/ticket/3614#ticket

This is an incremental update of #23, should be pushed after this to match changes
​https://bbpress.trac.wordpress.org/ticket/3614#ticket

[johnjamesjacoby]

@SirLouen I'm having some trouble applying this diff after 3613.

The diff for this issue doesn't seem to take the changes on 3613 into account.

Any ideas?

[johnjamesjacoby]

In 7357:

Tools - Code Improvement:

This commit modifies several PHP files to strictly adhere to the following PHPCS rules:

• WordPress.WP.I18n.NonSingularStringLiteralText
• WordPress.WP.PostsPerPage.posts_per_page_posts_per_page
• WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceAfterOpenParenthesis
• WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceBeforeCloseParenthesis
• WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterOpenParenthesis
• WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeCloseParenthesis
• WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter
• WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore
• WordPress.WhiteSpace.OperatorSpacing.SpacingAfter
• WordPress.WhiteSpace.OperatorSpacing.SpacingBefore

This commit does not include changes to the phpcs.xml.dist config file to add these rules yet - this will happen in a separate commit.

Props sirlouen.

In trunk, for 2.7.

See #3614.

[johnjamesjacoby]

In 7358:

Tools - Code Improvement: Updates to the phpcs.xml.dist config file.

Props sirlouen.

In trunk, for 2.7.

See #3614.

[johnjamesjacoby]

In 7359:

Tools - Code Improvement: Updates to the phpcs.xml.dist config file.

This commit reverts r7358, includes a few new exclusions, and ensures PHPCS has fully passes.

Props johnjamesjacoby, sirlouen.

In trunk, for 2.7.

Fixes #3614.

Fixed via: ​https://bbpress.trac.wordpress.org/changeset/7359

Thank you!