Skip to:
Content

bbPress.org

Opened 3 years ago

Closed 23 months ago

Last modified 23 months ago

#3235 closed defect (invalid)

admin area update puts a subscription on a revision post (RC7)

Reported by: wpturk Owned by: johnjamesjacoby
Milestone: Priority: high
Severity: normal Version: trunk
Component: API - Engagements Keywords: reporter-feedback
Cc:

Description

I am running the latest 2.6 RC7 and discovered problem regarding subscriptions:

This is before updating topic (post_id:54878) in admin area:

mysql> select * from forum_postmeta where meta_key="_bbp_subscription" ; 
+---------+---------+-------------------+------------+
| meta_id | post_id | meta_key          | meta_value |
+---------+---------+-------------------+------------+
.....
.....
|   35265 |   54878 | _bbp_subscription | 11743      |
+---------+---------+-------------------+------------+

This is after updating the topic (post_id:54878) in admin area:

mysql> select * from forum_postmeta where meta_key="_bbp_subscription" ; 
+---------+---------+-------------------+------------+
| meta_id | post_id | meta_key          | meta_value |
+---------+---------+-------------------+------------+
.....
.....
|   35265 |   54878 | _bbp_subscription | 11743      |
|   35280 |   54879 | _bbp_subscription | 1          |
+---------+---------+-------------------+------------+

admin save puts a subscription on a revision post (54879). I think this should be corrected.

Change History (11)

#1 @johnjamesjacoby
3 years ago

  • Component changed from General to API - Engagements
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby
  • Version set to trunk

#2 @johnjamesjacoby
3 years ago

This bug was introduced in r6811, as part of #3185.

Working on a fix now.

#3 @johnjamesjacoby
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6886:

Subscriptions: Do not add or remove subscriptions when editing via WordPress admin.

This change passes the current post ID through to bbp_is_user_subscribed(), ensuring that admin area subscriptions are saved to the correct topic ID (not revisions, etc...) while also not changing the subscriptions status.

Fixes #3235.

#4 @wpturk
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi John,

Unfortunately, this fix (6886) does not work completely. Wordpress Admin save is not putting subscription anymore (thats good) but existing user subscriptions are getting deleted.

Regards.

Last edited 2 years ago by wpturk (previous) (diff)

#5 @johnjamesjacoby
2 years ago

  • Keywords reporter-feedback added; needs-patch removed
  • Milestone changed from 2.6 to 2.6.1

Hi @wpturk!

I've done a thorough audit of the changes and callstack, and cannot duplicate your experience above.

I do not see where or how all existing user subscriptions could get deleted from editing a topic via WordPress Admin.

There is a function (bbp_remove_topic_from_all_subscriptions()) that is tasked with performing this action, but only on the spam, trash, and delete actions (not anything related to editing.)

Going to move this into the 2.6.1 milestone pending reporter feedback.

#6 @johnjamesjacoby
2 years ago

In 6918:

Subscriptions: clean up code comparisons and documentation.

This commit adds some inline documentation to provide a bit more clarity around what subnscriptions checks and actions are being taken, and adds parenthesis to nested comparisons to improve code readability.

See #3235.

#7 @johnjamesjacoby
2 years ago

  • Milestone changed from 2.6.1 to 2.6.2

Move these to 2.6.2.

#8 @johnjamesjacoby
2 years ago

  • Milestone changed from 2.6.2 to 2.6.3

#9 @johnjamesjacoby
23 months ago

  • Milestone changed from 2.6.3 to 2.7

@wpturk can you confirm if this is still happening for you?

#10 follow-up: @wpturk
23 months ago

  • Milestone 2.7 deleted
  • Resolution set to invalid
  • Status changed from reopened to closed

Hi John,

just tested it now. This is not the case anymore. It works fine. Thank you.

#11 in reply to: ↑ 10 @johnjamesjacoby
23 months ago

Replying to wpturk:

just tested it now. This is not the case anymore. It works fine. Thank you.

🙏

Note: See TracTickets for help on using tickets.