Changeset 6886

Timestamp:

12/20/2018 09:24:09 PM (4 years ago)

Author:

johnjamesjacoby

Message:

Subscriptions: Do not add or remove subscriptions when editing via WordPress admin.

This change passes the current post ID through to bbp_is_user_subscribed(), ensuring that admin area subscriptions are saved to the correct topic ID (not revisions, etc...) while also not changing the subscriptions status.

Fixes #3235.

File:

• trunk/src/includes/admin/metaboxes.php (modified) (2 diffs)

trunk/src/includes/admin/metaboxes.php

@@ -745 +745 @@
 function bbp_topic_subscriptions_metabox( $post ) {
 
+    // Current user subscription
+    $input_value = bbp_is_user_subscribed( bbp_get_current_user_id(), $post->ID )
+        ? 'bbp_subscribe' // maintain existing subscription
+        : '';             // do not add or remove subscription
+
     // Get user IDs
     $user_ids = bbp_get_subscribers( $post->ID );
@@ -750 +755 @@
     // Output
     ?>
-    <input name="bbp_topic_subscription" id="bbp_topic_subscription" type="hidden" value="bbp_subscribe" <?php bbp_form_topic_subscribed(); ?> />
+    <input name="bbp_topic_subscription" id="bbp_topic_subscription" type="hidden" value="<?php echo esc_attr( $input_value ); ?>" />
     <p><?php