Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2974 closed defect (bug) (fixed)

BuddyPress: Ensure bbp_is_single_topic() returns true on group topic pages

Reported by: r-a-y's profile r-a-y Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.2
Component: Extend - BuddyPress Keywords: has-patch
Cc:

Description

This is related to #2971.

If on a single topic page, the default theme enqueues some JS:
​https://bbpress.trac.wordpress.org/browser/tags/2.5.10/templates/default/bbpress-functions.php#L187

However, bbp_is_single_topic() returns false when on a BuddyPress group forum topic page, so the JS is never enqueued.

Attached patch filters 'bbp_is_single_topic' in the BuddyPress groups module so that bbp_is_single_topic() will return true on group forum topic pages.

Attachments (2)

2974.01.patch​ (1.1 KB) - added by r-a-y 9 years ago.
2974.02.patch​ (1.6 KB) - added by justinph 9 years ago.

Download all attachments as: .zip

Change History (6)

@r-a-y
9 years ago

@justinph
9 years ago

#1 @justinph
9 years ago

This issue causes an issue with ​some plugins that use the is_bbpress() function.

EDIT: 2974.02.patch is a mistake on my part. Please ignore. 2974.01.patch fixes the issue.

Last edited 9 years ago by justinph (previous) (diff)

#2 @johnjamesjacoby
9 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6220:

BuddyPress: Additional conditionals for group forum topic checks.

Fixes #2974. Props r-a-y.

#3 @johnjamesjacoby
9 years ago

In 6367:

BuddyPress: Filter bbp_is_single_forum for group forums.

Props r-a-y. Fixes #2727. See #2974.

#4 @johnjamesjacoby
9 years ago

In 6368:

BuddyPress: Update inline doc for group-forum filter. See #2974.

Note: See TracTickets for help on using tickets.