Skip to:

Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#2971 closed defect (bug) (fixed)

Threaded reply form JS does not work

Reported by: r-a-y's profile r-a-y Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: Appearance - Theme Compatibility Keywords: has-patch


Turn on threaded replies.

Next, visit a forum thread with at least two posts.

When you click on the "Reply" link for the second post, the following JS error occurs:

Not enough arguments to Node.insertBefore.

Attached patch fixes this by switching reply.parentNode.insertBefore(respond); to reply.parentNode.appendChild(respond);

Now the threaded reply form correctly shows up just beneath the forum post.

Tested on 2.5.10 and 2.6-trunk.

Attachments (1)

2971.01.patch (403 bytes) - added by r-a-y 8 years ago.

Download all attachments as: .zip

Change History (6)

8 years ago

#1 @r-a-y
8 years ago

If the reply form should show up before the forum post, let me know and I'll repatch.

#2 @r-a-y
8 years ago

#2994 was marked as a duplicate.

Patch in #2994 has an alternative way of solving the problem (see my comment above - comment:1):

Last edited 8 years ago by r-a-y (previous) (diff)

#3 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6096:

Replies: use appendChild vs. insertBefore for inline JS replies.

Fixes #2971. Props r-a-y.

#4 @netweb
7 years ago

#3082 was marked as a duplicate

#5 @chherbst
6 years ago

Would you please backport this to the 2.5.* branch! This is a serious bug with a very simple solution.

Note: See TracTickets for help on using tickets.