Skip to:
Content

bbPress.org

Opened 10 years ago

Last modified 5 days ago

#2970 new enhancement

Allow only topic authors and users who can moderate to add/remove tags from a topic

Reported by: Robkk Owned by:
Priority: normal Milestone: 2.7
Component: Component - Topic Tags Version: 2.2
Severity: normal Keywords: needs-patch needs-unit-tests
Cc:

Description

I believe regular participants shouldn't be able to just remove any topics existing tags, or that new users replying should be able to add any additional tags to a topic. Doesn't make sense to me.

I am not sure if this was a bug that was never identified before or normal behavior. I just feel it should be changed to what the title describes.

Yay or Nay Guys?

Change History (5)

#1 in reply to: ↑ description @netweb
10 years ago

  • Milestone Awaiting Review → Under Consideration
  • Version 2.5.9 → 2.2

Here's the current mapping for the user role Participant:

https://cldup.com/vnDF6ahCAG.png

Replying to Robkk:

I believe regular participants shouldn't be able to just remove any topics existing tags

Participants shouldn't be able to remove, edit, or delete topic tags, if they can then this is a bug

Replying to Robkk:

or that new users replying should be able to add any additional tags to a topic. Doesn't make sense to me.

Participants can add topic tags though

Spammers frequently add spammy topic tags to replies though when spamming a reply the topic tags added by that reply should also be removed.

#2 @johnjamesjacoby
10 years ago

So... I bet this is by design, because of old bbPress. Consider how anyone can add the mod-look tag, etc...

The bug is currently that the caps don't accurately reflect the behavior of wp_set_object_terms().

#3 @johnjamesjacoby
10 years ago

Which is also to say, the current functionality to allow all users the ability to modify tags is intentional.

I do think that cascading these caps downwards, and restricting things like this to the capabilities of forum or topic "moderators" is a great idea, though!

#4 @johnjamesjacoby
7 years ago

Still think this is a good idea. I haven't thought about it in a while, but we should work this out for a future release.

#5 @johnjamesjacoby
5 days ago

  • Keywords needs-patch needs-unit-tests added; 2nd-opinion dev-feedback removed
  • Milestone Under Consideration → 2.7
  • Type idea → enhancement

This still reproduces on trunk and the 2.6 branch.

Participants currently receive assign_topic_tags, and remove_topic_tag falls back to that capability. Topic and reply forms therefore allow any participant to add or remove tags from an existing topic. The focused reply-handler coverage explicitly preserves this behavior.

Recent topic-tag capability work added safe per-topic and per-tag filtering and separated global term management from forum-scoped moderation, but it did not implement the author restriction proposed here.

I think this should target 2.7 as an enhancement, rather than 2.6.20. Restricting existing topics to their authors and users who can moderate is a small implementation, but it changes longstanding collaborative-tagging behavior, including workflows such as participants adding mod-look.

A patch should keep initial tagging available during new-topic creation, scope assignment and removal on existing topics to the topic author or a capable moderator, preserve the existing capability filter, and cover forged reply submissions as well as author and moderator behavior.

Note: See TracTickets for help on using tickets.