Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2746 closed defect (bug) (fixed)

Remove deprecated jshint 'onevar" and 'trailing' option from .jshintrc

Reported by: netweb's profile netweb Owned by: netweb's profile netweb
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Tools - Build Keywords: has-patch commit
Cc:

Description (last modified by netweb)

Via ​#WP28236

A few things here....

Since we are now using JSHint v2.5 via grunt-contrib-jshint v0.10.0 in our package.json the onevar and trailing options in .jshintrc are pointless, support for both of these was removed in JSHint v2.5.

I've had my head in JSCS for the past couple of days and I'll create a JSCS ticket and link back here once done to investigate JSCS options further and to add support for these now removed onevar and trailing options via JSCS.

JSCS includes equivalent options for ease of migrating settings from JSHint to JSCS

See ​https://github.com/jshint/jshint/pull/1554

Change History (4)

#1 @netweb
8 years ago

  • Component changed from General to Build/Test Tools
  • Milestone changed from Awaiting Review to 2.6

#2 @netweb
8 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 5600:

Remove trailing option from .jshintrc, as of JSHint v2.5 trailing is no longer an option.
See ​https://github.com/jshint/jshint/pull/1554
Fixes #2746

#3 @netweb
8 years ago

  • Description modified (diff)
  • Summary changed from Remove jshint 'trailing' option from .jshintrc to Remove deprecated jshint 'onevar" and 'trailing' option from .jshintrc

#4 @netweb
8 years ago

In 5622:

Remove onevar from .jshintrc, as of JSHint v2.5 onevar is no longer an option.

See #2746

Note: See TracTickets for help on using tickets.