Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 2 years ago

#2745 closed defect (fixed)

BuddyPress: Do not attempt to run 'redirect_canonical' hook when on a RSS feed

Reported by: r-a-y Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.1
Component: Extend - BuddyPress Keywords: has-patch commit
Cc:

Description

On BBP_Forums_Group_Extension::redirect_canonical(), the bbp_is_single_topic() function is used. This function uses is_singular(), which throws a notice when on a BP group RSS feed. (See https://buddypress.trac.wordpress.org/ticket/6067.)

Attached patch is against trunk and bails out of BBP_Forums_Group_Extension::redirect_canonical() when on a BP group RSS feed. This fixes the notices from being shown.

Attachments (2)

2745.01.patch (488 bytes) - added by r-a-y 4 years ago.
2745.02.patch (447 bytes) - added by r-a-y 3 years ago.

Download all attachments as: .zip

Change History (6)

@r-a-y
4 years ago

#1 @netweb
4 years ago

  • Milestone changed from Awaiting Review to Under Consideration

@r-a-y
3 years ago

#2 @r-a-y
3 years ago

  • Summary changed from BuddyPress: Do not attempt to run 'redirect_canonical' hook when on a BP group RSS feed to BuddyPress: Do not attempt to run 'redirect_canonical' hook when on a RSS feed

Bug also occurs on BP user activity RSS feeds.

Decided to go with an is_feed() conditional instead, which catches both BP user activity and group RSS feeds.

Last edited 3 years ago by r-a-y (previous) (diff)

#3 @netweb
2 years ago

  • Keywords commit added
  • Milestone changed from Under Consideration to 2.6
  • Owner set to johnjamesjacoby
  • Version changed from 2.5.4 to 2.1

#4 @johnjamesjacoby
2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6383:

BuddyPress: Bail if in a feed.

Props r-a-y, netweb. Fixes #2745.

Note: See TracTickets for help on using tickets.