Accessibility: Templates - Breadcrumbs

[netweb]

via Karl Groves bbPress Accessibility Feedback ​https://gist.github.com/ntwb/c8f99df8a714ed028e2d

Suggested breadcrumb markup
Note: The stuff in the breadcrumb separator span should be CSS generated content.
In the following model it'd be: .bbp-breadcrumb ul li a::after{ content: ' ›'; }

Proposed:

<div class="bbp-breadcrumb">
    <ul>
        <li><a href="http://wp-test:8888/" class="bbp-breadcrumb-home">Home</a></li>
        <li><a href="http://wp-test:8888/?post_type=forum" class="bbp-breadcrumb-root">Forums</a></li>
        <li><span class="bbp-breadcrumb-current">Developers – General</span></li>
    </ul>
</div>

Current:

<div class="bbp-breadcrumb">
    <p>
        <a href="http://wp-test:8888/" class="bbp-breadcrumb-home">Home</a>
        <span class="bbp-breadcrumb-sep">›</span>
        <a href="http://wp-test:8888/?post_type=forum/" class="bbp-breadcrumb-root">Forums</a>
        <span class="bbp-breadcrumb-sep">›</span>
        <span class="bbp-breadcrumb-current">Developers – General</span>
    </p>
</div>

[netweb]

A basic plugin to achieve 'close' to the intended results is here: ​https://gist.github.com/ntwb/fe3dec3ac219cd0ef322

It needs some CSS tweaks though the HTML of the breadcrumbs is:

<div class="bbp-breadcrumb">
    <ul>
        <li><a href="http://wp-test:8888/" class="bbp-breadcrumb-home">Home</a></li>
        <li><a href="http://wp-test:8888/forums/" class="bbp-breadcrumb-root">Forums</a></li>
        <li><span class="bbp-breadcrumb-current">Developers – General</span></li>
    </ul>
</div>

As to a patch for this ticket in it's current form by moving the separator to CSS is unlikely.

Users have the ability as the above plugin shows to customize the breadcrumbs quite significantly already and this includes the separator character, 'out of the box' bbPress also supports LTR and RTL:

$args['sep'] = is_rtl() ? __( '‹', 'bbpress' ) : __( '›', 'bbpress' );

Moving the separator to CSS using a::after{ content: ' ›'; } will remove the ability for users to filter the separator and will break backwards compatibility and not allow us to switch separators for RTL CSS.

Changing the default breadcrumbs to use a list item format (using the defaults per the above plugin) should be fine.

[johnjamesjacoby]

Bumping to 2.7 so we can clear out Awaiting Review and 2.6 milestones.

[johnjamesjacoby]

Bumping all 2.7 to 2.8 milestone.

[Robkk]

Uses ordered list instead and some different CSS.

[Robkk]

Back to using unordered list.

[netweb]

Related: #2269