Skip to:
Content

bbPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#2500 closed defect (bug) (fixed)

Wrong action login_form placement in the template form-user-login.php

Reported by: icu0755's profile icu0755 Owned by: netweb's profile netweb
Milestone: 2.5.3 Priority: normal
Severity: normal Version: trunk
Component: API - Actions/Filters Keywords: commit
Cc:

Description

If you have a look into the templates form-user-register.php and form-user-login.php you could see they are almost the same beside do_action placement.

I suggest to move <?php do_action( 'login_form' ); ?> out of the bbp-submit-wrapper in the next releases. That will help to have the same markup for these templates using the wordpress hooks system.

Please look at the original wordpress login/register forms.

Attachments (1)

2500.diff​ (1.3 KB) - added by netweb 11 years ago.

Download all attachments as: .zip

Change History (5)

@netweb
11 years ago

#1 @johnjamesjacoby
11 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.5.3

Looks good to me. Run it!

#2 @johnjamesjacoby
11 years ago

  • Owner set to netweb

#3 @netweb
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5240:

Relocate login_form action hook outside bbp-submit-wrapper form submit wrapper in form-user-login.php and form-user-lost-pass.php templates. Props icu0755. Fixes #2500 (2.5 branch)

#4 @netweb
11 years ago

In 5241:

Relocate login_form action hook outside bbp-submit-wrapper form submit wrapper in form-user-login.php and form-user-lost-pass.php templates. Props icu0755. Fixes #2500 (trunk)

Note: See TracTickets for help on using tickets.