Topic Subscribed status is not being kept after a new reply is created

[netweb]

Topic Subscriptions behaving badly!

Repro

• Subscribe to a topic via the topic 'subscribe' link
• Ensure that you now see 'Subscribed'
• Post a reply without checking the 'Notify me of follow-up replies via email' checkbox
• Check the topic's 'Subscribe' link and you will see it displayed as 'Subscribe' and you are no longer subscribed to the topic

Expected

• 'Subscribe' link should still be showing as 'Subscribed' and you should remain subscribed to the topic.

Will take a look around the code tomorrow.

[netweb]

Workaround

• When replying to a topic check the 'Notify me of follow-up replies via email' checkbox when submitting a new reply.

[johnjamesjacoby]

My guess is this has something to do with under the hood changes to bbp_is_user_subscribed() when forum subscriptions were introduced. Looking into it.

[johnjamesjacoby]

In 5236:

Use more explicit subscriptions functions for form output. Fixes #2493. (trunk)

[johnjamesjacoby]

In 5237:

Use more explicit subscriptions functions for form output. Fixes #2493. (2.5 branch)