Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2492 closed defect (fixed)

Wrong parameters to home_url in bbp_verify_nonce_request

Reported by: MZAWeb Owned by: johnjamesjacoby
Milestone: 2.5.3 Priority: normal
Severity: normal Version: 2.1
Component: General Keywords: needs-patch
Cc:

Description

We're doing:

$parsed_home = parse_url( home_url( '/', ( is_ssl() ? 'https://' : 'http://' ) ) );

and the params should be 'https' or 'http', without the :

This bug is making the check fail in the admin while on ssl.

Will patch later if no one beats me to it.

Change History (3)

#1 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 2.5.3

#2 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5238:

Use correct scheme strings in bbp_verify_nonce_request(). Fixes false negative bbPress-specific nonce checks in functions and methods that do not use WordPress's traditional nonce/die pairing. Fixes #2492. Props MZAWeb. (2.5 branch)

#3 @johnjamesjacoby
8 years ago

In 5239:

Use correct scheme strings in bbp_verify_nonce_request(). Fixes false negative bbPress-specific nonce checks in functions and methods that do not use WordPress's traditional nonce/die pairing. Fixes #2492. Props MZAWeb. (trunk)

Note: See TracTickets for help on using tickets.