bbP's internal private and forum IDs not updated when adding a forum into BuddyPress

[r-a-y]

If you add a forum to a private or hidden group in BuddyPress, bbPress does not record that forum ID into its '_bbp_{visibility}_forums' DB option.

This creates problems as the Recent Topics / Replies widgets, which rely on these DB options, will show private forum content to the public.

To address this, I decided to move the utility function - bbp_admin_repair_forum_visibility() - from admin/tools.php into forums/functions.php so we can use it in a more general sense like I have in /extend/buddypress/group.php.

Yes, this is more of a brute-force way of fixing the issue, but this also ensures that all forum IDs in bbPress are updated.

If moving the bbp_admin_repair_forum_visibility() function isn't desired, then some form of update_option() approach will be needed.

[johnjamesjacoby]

In 5017:

Introduce bbp_repair_forum_visibility() and use it:

• when creating a new BuddyPress Group Forum
• in the bbp_admin_repair_forum_visibility() tool

Fixes issues with new group forums not bumping the private/hidden forum ID's. Props r-a-y. Fixes #2349.