Opened 11 years ago
Closed 11 years ago
#2348 closed defect (bug) (fixed)
Make Open/Close permissions consistently use 'edit_topic' instead of 'moderate'
Reported by: | jondavidjohn | Owned by: | |
---|---|---|---|
Milestone: | 2.4 | Priority: | normal |
Severity: | normal | Version: | 2.1 |
Component: | Component - Topics | Keywords: | reporter-feedback |
Cc: |
Description
This patch aims to make the Open/Close functionality consistently require 'edit_topic' capability.
There were a few places that required the 'moderate' capability, but here you only require the 'edit_topic' capability, which seems to be the most correct requirement.
http://bbpress.trac.wordpress.org/browser/trunk/includes/topics/functions.php#L2019
Attachments (1)
Change History (5)
#2
@
11 years ago
- Keywords reporter-feedback added; has-patch removed
It's possible there is a bug in this logic, since there appear to be some nested capability checks.
Though... the two checks you're pointing out here seem exclusive to moderators, since you'd likely not want a topic author to be able to close their own topic, and leave that up to conversation moderators to decide.
Leaving this open, to review these quickly in 2.4. Any other thoughts on this?
Patch to only require 'edit_topic' for topic toggle actions.