BP activity should respect hide_sitewide rules

[boonebgorges]

Currently, when posting a new topic or reply in a BP group, bbPress bails in the following situation:

if ( !bbp_is_forum_public( $forum_id, false ) )
    return false;

This is incongruent with BP's native behavior, which posts activity items for private/hidden group content, but marks it hide_sitewide = true when creating the activity item.

[johnjamesjacoby]

This makes sense. Should really have an index on the status column. Should also have been an int for speedy IN queries.

[johnjamesjacoby]

Worth fixing for 2.2.3.

[johnjamesjacoby]

(In [4538]) BuddyPress Activity:

• When creating activity stream items, utilize 'hide_sitewide' instead of not recording any activity at all.
• Hat-tip boonebgorges.
• Fixes #2081 (trunk)

[johnjamesjacoby]

(In [4539]) Invert the public forum check (see #2081)

[johnjamesjacoby]

(In [4540]) BuddyPress Activity:

• When creating activity stream items, utilize 'hide_sitewide' instead of not recording any activity at all.
• Hat-tip boonebgorges.
• Fixes #2081 (2.2 branch)

[netweb]

In 5741:

Tests: Improved performance of user component count function tests, now 33⅓% faster
Props thebrandonallen. See #2081

[netweb]

In 5766:

Tests: Improved performance and use bbp_clean_post_cache() in topics template counts function tests

Props thebrandonallen. See #2081