BP group forum topic list breaks beyond first page

[boonebgorges]

URLs like http://example.com/groups/foo/forum/page/2 do not work properly - they lead to the "Oh bother!" screen. The problem is in BBP_Forums_Group_Extension::display_forums(), where you detect whether you're looking at a group forum root by checking to see whether the appropriate bp_action_variable() is empty. In the case of pagination, that variable will not be empty - it will be 'page'.

I've attached a patch with a somewhat ugly, but functional, patch. Please feel free to amend and abstract as you see fit.

(Sorry about the whitespace stuff - you should turn on trimming in your IDE :) )

[johnjamesjacoby]

(Sorry about the whitespace stuff - you should turn on trimming in your IDE :) )

It's turned off so it doesn't pollute patches. :)

Moving to 2.2.3.

[johnjamesjacoby]

(In [4536]) BuddyPress Groups:

• Fix issue causing paginated group forum requests to incorrectly fail.
• Hat-tip boonebgorges.
• Fixes #2080 (2.2 branch)

[johnjamesjacoby]

(In [4537]) BuddyPress Groups:

• Fix issue causing paginated group forum requests to incorrectly fail.
• Hat-tip boonebgorges.
• Fixes #2080 (trunk)