Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2080 closed defect (fixed)

BP group forum topic list breaks beyond first page

Reported by: boonebgorges Owned by:
Milestone: 2.2.3 Priority: high
Severity: major Version: 2.2
Component: Extend - BuddyPress Keywords:
Cc:

Description

URLs like http://example.com/groups/foo/forum/page/2 do not work properly - they lead to the "Oh bother!" screen. The problem is in BBP_Forums_Group_Extension::display_forums(), where you detect whether you're looking at a group forum root by checking to see whether the appropriate bp_action_variable() is empty. In the case of pagination, that variable will not be empty - it will be 'page'.

I've attached a patch with a somewhat ugly, but functional, patch. Please feel free to amend and abstract as you see fit.

(Sorry about the whitespace stuff - you should turn on trimming in your IDE :) )

Attachments (1)

2080.patch (2.2 KB) - added by boonebgorges 9 years ago.

Download all attachments as: .zip

Change History (4)

@boonebgorges
9 years ago

#1 @johnjamesjacoby
9 years ago

  • Milestone changed from Awaiting Review to 2.2.3

(Sorry about the whitespace stuff - you should turn on trimming in your IDE :) )

It's turned off so it doesn't pollute patches. :)

Moving to 2.2.3.

#2 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4536]) BuddyPress Groups:

  • Fix issue causing paginated group forum requests to incorrectly fail.
  • Hat-tip boonebgorges.
  • Fixes #2080 (2.2 branch)

#3 @johnjamesjacoby
9 years ago

(In [4537]) BuddyPress Groups:

  • Fix issue causing paginated group forum requests to incorrectly fail.
  • Hat-tip boonebgorges.
  • Fixes #2080 (trunk)
Note: See TracTickets for help on using tickets.