Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#2061 closed defect (bug) (fixed)

post_parent and exclude arguments for bbp_dropdown() not working

Reported by: jmdodd's profile jmdodd Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.1
Component: Tools - Code Improvements Keywords:
Cc:

Description

On topic merge and split views, destination topic dropdown is supposed to only include topics from the current forum, but includes all topics. This is because bbp_dropdown() uses the child_of argument instead of post_parent for its call to get_posts(), and does not use the exclude parameter at all.

This also affect forum, topic, and reply admin-side "Parent" attribute metaboxes.

Attachments (1)

2061.diff​ (2.9 KB) - added by jmdodd 13 years ago.

Download all attachments as: .zip

Change History (4)

@jmdodd
13 years ago

#1 @johnjamesjacoby
13 years ago

  • Milestone changed from Awaiting Review to 2.3

#2 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4518]) Dropdown:

  • Use 'post_parent' instead of 'child_of' in bbp_get_dropdown().
  • Add 'exclude' to array of default arguments.
  • Fixes bug with not excluding post ID's, and not using the correct post parent ID.
  • Props jmdodd.
  • Fixes #2061.

#3 @johnjamesjacoby
13 years ago

(In [4519]) Use 'post_parent' instead of 'child_of' in bbp_get_dropdown() usages. See #2061.

Note: See TracTickets for help on using tickets.