Skip to:
Content

Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#1926 closed enhancement (fixed)

Add zero margin to forum list items

Reported by: ryanimel Owned by:
Milestone: 2.1.3 Priority: normal
Severity: normal Version: 2.1
Component: Theme Compatability Keywords: has-patch
Cc: ryanimel, stephen@…

Description

Twenty Twelve testing sent me here: since Twenty Twelve is a bit more specific with its list styles (.entry-content li {} rather than just li {}) than either Twenty Ten or Eleven were. So bbPress gets pushed around a little bit.

Screenshot: http://cl.ly/image/2x1c17033d41

So I suggest adding margin: 0; to the #bbpress-forums li {} in line 62 of bbpress.css.

Some themes might be just as specific as this, so dropping in a margin: 0; just to be safe might be helpful in more than just this situation. That was the discussion that led to suggesting this as a patch for bbPress rather than one for Twenty Twelve.

(Apologies for not including a patch and taking care of the addition myself. Local SVN is out of whack on my laptop; I'll get to it when home if it doesn't happen before then.)

Beeeeeees''

Attachments (1)

1926.diff (745 bytes) - added by Mamaduka 21 months ago.

Download all attachments as: .zip

Change History (9)

comment:1 ryanimel21 months ago

  • Cc ryanimel added

Mamaduka21 months ago

comment:2 Mamaduka21 months ago

1926.diff

  • Adds margin: 0; to bbpress.css and bbpress-rtl.css
  • Removes redundant list-style: none; property from bbpress.css, as list-style is inherited from ol and ul to li elements.

comment:3 Mamaduka21 months ago

  • Component changed from General to Theme Compatability
  • Keywords has-patch added

comment:4 johnjamesjacoby21 months ago

  • Milestone changed from Awaiting Review to 2.1.3

Thanks for the patch!

comment:5 netweb21 months ago

  • Cc stephen@… added

comment:7 johnjamesjacoby21 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4142]) Theme Compat:

  • Additional CSS to prevent gaps in list items.
  • Fixes #1926.
  • See #1897.
  • For 2.2.
  • Props mamaduka.

comment:8 johnjamesjacoby21 months ago

(In [4143]) Theme Compat:

  • Additional CSS to prevent gaps in list items.
  • Fixes #1926.
  • See #1897.
  • For 2.1 branch.
  • Props mamaduka.
Note: See TracTickets for help on using tickets.