Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1798 closed defect (bug) (fixed)

Add Translation Context for "Open" String For Topics/Forums

Reported by: daveshine Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: Locale - i18n/l10n Keywords:
Cc:

Description

The "Open" string is used for type of forum but also for opening forums or topics. In English language it's the same word for both but not in other languages, for example in German.

If you add _x( and context string this would solve it.

Affecting
(1) bbp-admin/bbp-topics.php around line 831, I'll suggest to change to:

_x( 'Open', 'Translators: To open topic',  'bbpress' )

(2) bbp-includes/bbp-forum-templates.php around line 2130, I'll suggest to change to:

_x( 'Open', 'Translators: Status of Forum',   'bbpress' )

(3) bbp-includes/bbp-topic-templates.php around line 2332, I'll suggest to change to:

_x( 'Open', 'Translators: Status of Topic',  'bbpress' )

For example in German (1) has to be translated as "Öffnen" but (2) + (3) have to be translated as "Offen".

May seem as a minor thing for some but to not confuse forum admins it's really important to improve the gettext strings here!

Change History (5)

#1 @daveshine
10 years ago

  • Component changed from Actions/Filters to i18n/l10n

#2 @johnjamesjacoby
10 years ago

  • Milestone changed from Awaiting Review to 2.1

#3 @johnjamesjacoby
10 years ago

Something tells me there are many other places we could do a better job of explaining the context of our strings.

#4 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3823]) Add context to 'Open' and 'Close' strings. Props daveshine. Fixes #1798.

#5 @johnjamesjacoby
10 years ago

(In [3824]) Use esc_attr__ where appropriate. See #1798.

Last edited 10 years ago by johnjamesjacoby (previous) (diff)
Note: See TracTickets for help on using tickets.