Skip to:
Content

bbPress.org

Opened 12 years ago

Closed 12 years ago

#1797 closed defect (bug) (fixed)

Translations of Widget Titles and Description are Not Showing

Reported by: daveshine's profile daveshine Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: API - Widgets Keywords:
Cc:

Description

On all my installs I always have the issue that all the bbPress Widget titles and their descriptions are not showing the translated strings. This was affecting my older 2.0.x installs as well as the sites with 2.1 branch running.

I checked this nearly a hundred times or more that it's not on my behalf, also checked code of the Widgets, also the loadings calls for the textdomain but couldn't find anything. Of course, I also checked language files numerous times: .mo/.po files are fully translated and all gets displayed except for mentioned widget stuff...

I really don't know why it's not showing, so just posting here for other devs to check in.

Change History (7)

#1 @daveshine
12 years ago

  • Component changed from Actions/Filters to Widgets

#2 @johnjamesjacoby
12 years ago

  • Milestone changed from Awaiting Review to 2.1

I see two strings that are not translated correctly. Only 1 title is missing a translation, the rest should be working correctly.

#3 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3825]) Audit widgets for untranslated or incorrectly translated strings.

  • Remove PHP4 compat from widgets
  • Add missing translation to recent replies widget
  • Add brackets to titles to better group widgets together
  • Fixes #1797

#4 @daveshine
12 years ago

Unfortunately the display of the translations in admin for Widget Title and Widget Description in the available widgets list does STILL NOT show up. Just tested with latest trunk version.

Maybe this has to do with the loading priority: As of updating my "bbPress Search Widget" plugin I had the same issue: my translations were loaded on the "init" hook with default priority - nothing did show up in title/description! I had to change the priority down to "1" to have them display! Really strange!

I assume this is also a reason for the same issue bbPress 2.0/2.1. I tested to change the priority of the actions loading in trunk version of "/bbpress.php" also to "1" but here it didn't do anything but maybe I just did the wrong way...

Only to report this, maybe someone else has a clue for this?

#5 follow-up: @daveshine
12 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The problem still exists for 2.1 RC releases! I have complete translation files, all translations are showing except for the bbPress Widget titles and descriptions in the admin! If I place a widget the strings regarding the widget form will show, but not it's title and description.

As stated in the opening ticket here I assume wrong loading priorities.

This whole thing is really annoying as it exists since the 2.0 final releases, as long as I remember it was not there in the 2.0 betas of last year...

(Would really hope for a fix, as this gets me problems with some clients the longer it exists... Thanks!)

#6 in reply to: ↑ 5 @cnorris23
12 years ago

Replying to daveshine:

As stated in the opening ticket here I assume wrong loading priorities.

This seems to be the case. The hook, widgets_init, is run on init priority 1. The bbPress textdomain is run with bbp_load_textdomain, which is attached to bbp_init priority 2, which is attached to init priority 10. The load_(*_)textdomain functions can be loaded as early as plugins_loaded, so bbp_load_textdomain should probably be moved to bbp_loaded.

#7 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [4035]) Languages:

  • Move 'bbp_load_textdomain' action to 'bbp_loaded' from 'bbp_init.'
  • Loads early to allow widget titles to be translated.
  • Fixes #1797.
  • Props daveshine, cnorris23.
Note: See TracTickets for help on using tickets.