Opened 14 years ago
Last modified 9 years ago
#1430 assigned task (blessed)
Show pingbacks on topic page
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General - Integration | Keywords: | needs-refresh |
Cc: | wordpress@…, nashwan.doaqan@…, pippin@… |
Description
- We can't display pingbacks within the replies loop because replies are posts while pingbacks are comments, so we would probably need to display the pingbacks below the replies.
- Also add an option to disable pingbacks or use the existing one.
Attachments (7)
Change History (38)
#1
@
14 years ago
- Milestone changed from Plugin to Plugin - Future Release
- Priority changed from high to normal
#2
@
14 years ago
We should atleast decide where the pingbacks would be stored. Either in comments or post type. Otherwise it would be a problem for the importer.
#3
@
14 years ago
I don't see any reason to recode pingbacks, so using the existing comment method seems appropriate.
#4
@
13 years ago
- Milestone changed from 2.1 to Future Release
Moving to future release. No time to fit this into 2.1.
#5
@
12 years ago
I'd like to take a pass on this one.
We need to get both the main topic pingbacks and all the replies one, right? and show a div at the bottom with all? Also, do we want a setting to disable or just a theme decision?
Opinions?
#7
@
12 years ago
- Owner set to MZAWeb
- Status changed from new to assigned
After dev chat:
1) add an option to show/hide
2) do it as template part + widget (like stats)
3) profile and see if custom sql makes more sense
#10
@
12 years ago
After dev scrum:
1) Make this a plugin
2) Check the possibility of collaboration with #2036
3) Test both grouping all pingbacks (topic+replies) at the bottom or having each reply pingbacks on the replies, and the topic pingbacks at the bottom
#11
@
12 years ago
This is almost done. The latest is here if someone wants to take a look: https://github.com/MZAWeb/bbpress-pingbacks
I've added settings to selectively show/hide topic pingbacks, replies pingbacks and to filter only internal pingbacks (same domain). Also, it's injecting the templates into the stack, so users can override them in their themes.
What's not done yet:
1) Design. I didn't even include a css yet. I'll do my best, but I could seriously use some help in this regard.
2) Topic pingbacks are not usable, because of #2280
3) New replies are not pinging urls, but I'm close to fix that.
#14
@
12 years ago
If no one beats me to it I will take a look at the CSS (and the patch) in the next few days.
#15
@
12 years ago
This is 100% blocked by http://core.trac.wordpress.org/ticket/19744
#16
@
12 years ago
It seems that http://core.trac.wordpress.org/ticket/19744 is going out on 3.7.
I'll make sure my plugin still works with the latest bbPress trunk.
#17
@
12 years ago
Ok, assuming @wonderboymusic patch goes in for WP19744, this plugin works. It's pretty neat, actually. You can even have pingbacks between replies in the same forum.
I'll need some volunteer to make the template look nice, though. Send PR or something.
https://github.com/MZAWeb/bbpress-pingbacks
#19
@
11 years ago
In attachment:1430-converter.php.diff we should also change converter.php to set the 'default' imported topics & replies 'ping status' to 'open'.
We should also include a 'Repair Tool' and/or database update to change any existing 'ping_status' from 'closed' to 'open' as this will be needed for anyone who has previously migrated from another forum package to bbPress.
#20
@
11 years ago
- Keywords needs-refresh added
- Milestone changed from Future Release to 2.6
As #WP19744 is in, lets have a look at this for bbPress 2.6
#22
@
11 years ago
Pingmageddon?
Repro
- Enable this setting
- Import a forum with internal links (even external links)
- Weeeeeee, look at all the shiny new pingbacks
...downloading plugin to test above theory...
#24
@
11 years ago
The attached 5 files are an extremely rough first pass at the templates that I used for the 1430-Templates.PNG screenshot.
1430-Converter-CSS.patch
<- bbpress.css & converter.phploop-reply-pingbacks.php
loop-single-reply-pingback.php
loop-single-topic-pingback.php
loop-topic-pingbacks.php
Once #2486 is committed, I'll take a another shot at cleaning these up.
#26
@
11 years ago
- Milestone changed from 2.7 to 2.6
I think this would be a great addition to coincide with #2498 in 2.6
All that is left to do is update the plugin as a patch for core and tweak the templates.
#27
@
11 years ago
Note: Needs testing -> After creating a topic revision the comment_status is changed to closed.
Moving to future release and changing priority to normal. This is something that would be nice to have, but isn't something I see within the scope of the first release.