Changeset 6897 for trunk/src/includes/admin/tools.php

Timestamp:

01/29/2019 04:38:37 AM (6 years ago)

Author:

johnjamesjacoby

Message:

Upgrades: append upgrade count to "Tools" if there are pending upgrades

• Add function and method to tweak the $menu global
• Add styling for count in nav-tab-wrapper UI

This change adds a span.awaiting-mod wrapper around the pending upgrade count in a few strategic locations around the WordPress Admin UI.

See #3244.

File:

• trunk/src/includes/admin/tools.php (modified) (2 diffs)

trunk/src/includes/admin/tools.php

@@ -481 +481 @@
             $tab_class  = $is_current ? $active_class : $idle_class;
             $tab_url    = add_query_arg( array( 'page' => $tab['page'] ), admin_url( 'tools.php' ) );
-            $tabs_html .= '<a href="' . esc_url( $tab_url ) . '" class="' . esc_attr( $tab_class ) . '">' . esc_html( $tab['name'] ) . '</a>';
+
+            // Tab name is not escaped - may contain HTML
+            $tabs_html .= '<a href="' . esc_url( $tab_url ) . '" class="' . esc_attr( $tab_class ) . '">' . $tab['name'] . '</a>';
         }
 
@@ -515 +517 @@
             'func' => 'bbp_admin_upgrade_page',
             'cap'  => 'bbp_tools_upgrade_page',
-            'name' => esc_html__( 'Upgrade Forums', 'bbpress' ),
+            'name' => bbp_maybe_append_pending_upgrade_count( esc_html__( 'Upgrade Forums', 'bbpress' ) ),
 
             // Deprecated 2.6.0