Skip to:

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#3244 closed defect (bug) (fixed)

Upgrade UI/Flow for large installs

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: high
Severity: normal Version: trunk
Component: General - Administration Keywords: commit


When upgrading from 2.5 to 2.6, the way Favorites and Subscriptions were stored in the database has changed, and an upgrade routine runs automatically on sites with fewer than 10k users.

For large installs, however, there currently is not a clear UI/path/flow to guide them through manually running the necessary tools and routines.

Right now, there is no history of when these tools ran or what the outcome was (did it succeed/finish, etc...) which tangentially means there is no way to know if it needs to be run.

And if we knew how many upgrades needed to be run, we could add bubbles to the Tools admin menu and the Upgrades tab to provide Keymasters a bit of guidance.

I strongly prefer not to use an Admin Notice for this.

Attachments (2)

Screen Shot 2019-01-24 at 5.17.24 PM.png (1006.3 KB) - added by johnjamesjacoby 5 years ago.
Current Tools > Upgrades screen
Screen Shot 2019-01-28 at 6.17.55 PM.png (362.1 KB) - added by johnjamesjacoby 5 years ago.
Ability to filter upgrades by version

Download all attachments as: .zip

Change History (14)

5 years ago

Current Tools > Upgrades screen

#2 @johnjamesjacoby
5 years ago

In 6890:

Upgrades: add support for version key in repair tool registration.

This will get used by individual tools, to provide a UI for routines that need to be run between version upgrades.

See #3244.

#3 @johnjamesjacoby
5 years ago

In 6892:

Upgrades: add version and update strings to repair tools.

This change adds a version property to the relevant upgrades, and removes some redundant information from each description.

See #3244.

#4 @johnjamesjacoby
5 years ago

In 6893:

Upgrades: add column width styling to tools list tables.

This ensures that columns are usually wide enough to fit their anticipated contents.

See #3244.

#5 @johnjamesjacoby
5 years ago

In 6894:

Upgrades: add support for "Version" filter & links in list table.

  • Adds functions for outputting in a table row and select dropdown
  • Adds a function to allow special translating of version numbers
  • Adds numerous improvements for PHP 7.3 compat
  • Adds escaping and formatting in several places where it was previously omitted
  • Adds — to empty columns
  • Adds functions for getting the current page ID

See #3244.

5 years ago

Ability to filter upgrades by version

#6 @johnjamesjacoby
5 years ago

In 6895:

Upgrades: add "Version" column to upgrades list table.

See #3244.

#7 @johnjamesjacoby
5 years ago

In 6896:

Upgrades: change skipped upgrades to pending upgrade

  • Add functions for managing pending upgrades
  • Use IDs instead of strings for active tools tab
  • Add classes and hr for related H1's
  • Update registered option key name
  • Add skipped upgrades to pending upgrades array
  • Add span to allowed tags in notices

These changes are necessary to bring adimn pages up to speed with WordPress Admin UI mark-up, in relation to the database upgrade notice.

See #3244.

#8 @johnjamesjacoby
5 years ago

In 6897:

Upgrades: append upgrade count to "Tools" if there are pending upgrades

  • Add function and method to tweak the $menu global
  • Add styling for count in nav-tab-wrapper UI

This change adds a span.awaiting-mod wrapper around the pending upgrade count in a few strategic locations around the WordPress Admin UI.

See #3244.

#9 @johnjamesjacoby
5 years ago

  • Keywords commit added; needs-patch removed

All that’s left to do here is map repair tool IDs from the new pending upgrades option, to versions, and automatically link to the correct filter.

I ran out of time for this tonight, and will finish tomorrow.

#10 @johnjamesjacoby
5 years ago

In 6925:

Tools: Make a few columns sortable.

This commit adds a small UX improvement to the Repair and Upgrade tools pages, allowing for these lengthy lists to be sorted.

See #3244.

#11 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6926:

Upgrades: Link to pending upgrades, if there are any.

This commit modifies the "Upgrade Forums" page by adding Statuses to filter by, specifically for pending upgrades. This allows bbPress to link directly to the upgrades that need doing, rather than the generic page itself.

Along with this commit are accompanying styling tweaks and helper functions to make this functionality possible.

Fixes #3244.

#12 @johnjamesjacoby
5 years ago

#3276 was marked as a duplicate.

Note: See TracTickets for help on using tickets.