Changeset 6246 for trunk/src/includes/replies/functions.php

Timestamp:

01/16/2017 05:22:53 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Replies: Update bbp_thread_replies() to skip user profile pages.

• Move from core/options to replies/functions, since this isn't directly an option
• Add ! bbp_is_single_user_replies() check to force false if so
• Update threaded replies pagination to re-include verbiage.

Fixes #3002.

File:

• trunk/src/includes/replies/functions.php (modified) (1 diff)

trunk/src/includes/replies/functions.php

@@ -2505 +2505 @@
 
 /**
- * List replies
+ * Are replies threaded?
+ *
+ * @since 2.4.0 bbPress (r4944)
+ * @since 2.6.0 bbPress (r6245) Always false on user profile reply pages
+ *
+ * @param bool $default Optional. Default value true
+ * @uses apply_filters() Calls 'bbp_thread_replies' with the calculated value and
+ *                        the thread replies depth
+ * @uses get_option() To get thread replies option
+ * @return bool Are replies threaded?
+ */
+function bbp_thread_replies() {
+    $depth = bbp_thread_replies_depth();
+    $allow = bbp_allow_threaded_replies();
+
+    // Never thread replies on user profile pages. It looks weird, and we know
+    // it is undesirable for the majority of installations.
+    if ( bbp_is_single_user_replies() ) {
+        $retval = false;
+    } else {
+        $retval = (bool) ( ( $depth >= 2 ) && ( true === $allow ) );
+    }
+
+    return (bool) apply_filters( 'bbp_thread_replies', $retval, $depth, $allow );
+}
+
+/**
+ * List threaded replies
  *
  * @since 2.4.0 bbPress (r4944)