Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

#3002 closed defect (bug) (fixed)

threaded reply layout present in replies created area of user profile

Reported by: robkk's profile Robkk Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.4
Component: Component - Replies Keywords: has-screenshots has-patch commit
Cc:

Description

Came across this while I was messing with some threaded reply design.

While having reply threading enabled, the replies in a users forum profile show up threaded if a users responds to their own reply.

I think that the threaded reply layout should not be present in the replies created section of a forum profile.

It should have the default unthreaded layout in this area in my opinion.

Attachments (2)

threaded layout present in replies created area of user profile.png​ (152.7 KB) - added by Robkk 8 years ago.
3002.patch​ (440 bytes) - added by Robkk 8 years ago.
Patch adds a conditional to output threaded replies only on single topic pages only. Tested and works with using the single topic shortcode.

Download all attachments as: .zip

Change History (6)

@Robkk
8 years ago

#1 @thebrandonallen
8 years ago

+1. Off the top of my head, this would probably just need a conditional check for bbp_is_single_user_profile() before we do threaded replies.

@Robkk
8 years ago

Patch adds a conditional to output threaded replies only on single topic pages only. Tested and works with using the single topic shortcode.

#2 @thebrandonallen
8 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 2.6
  • Version set to 2.4

Thanks @Robkk!

You picked the better conditional ;)

#3 @johnjamesjacoby
8 years ago

  • Keywords commit added
  • Owner set to johnjamesjacoby

Huh. That's interesting.

The bbp_thread_replies() function exists as the place to do the JIT check (whether replies should be threaded or not for the current conditions) so I'll alter your patch to intercept this there.

#4 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6246:

Replies: Update bbp_thread_replies() to skip user profile pages.

  • Move from core/options to replies/functions, since this isn't directly an option
  • Add ! bbp_is_single_user_replies() check to force false if so
  • Update threaded replies pagination to re-include verbiage.

Fixes #3002.

Note: See TracTickets for help on using tickets.