Skip to:
Content

bbPress.org

Opened 18 years ago

Closed 17 years ago

#949 closed defect (bug) (fixed)

Nonsemantic markup in required form fields

Reported by: mdawaffe's profile mdawaffe Owned by:
Milestone: 1.0 Priority: normal
Severity: normal Version: 1.0-rc-2
Component: General - Administration Keywords: semantic
Cc:

Description

We currently output <sup class="required">*</sup> for required form inputs. I'm unclear if this is decent semantic markup, and, when it is outputted by template functions, is not very nice to theme authors.

Attached replaces the markup with generated content from CSS.

I'm not that worried about it not working in IE. Theme authors can use the CSS classes to change background colors or whatever if they're interested.

Thoughts?

Attachments (1)

949.diff (3.8 KB) - added by mdawaffe 18 years ago.

Download all attachments as: .zip

Change History (4)

@mdawaffe
18 years ago

#1 @sambauers
18 years ago

Having forms in tables isn't semantically correct to start with :)

I'm not sure about using <sup> as we do, but I don't think CSS generated content is particularly friendly to assisted access devices (I could be *completely* wrong though).

If we are going to change the structure of our forms I think we should be complete about it.

#2 @sambauers
17 years ago

  • Milestone changed from 1.0-beta & XML-RPC to 1.0

#3 @sambauers
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2177]) Prettier Kakumei including a more semantic form markup. Fixes #949

Note: See TracTickets for help on using tickets.