BuddyPress: Pending group topics cannot be viewed

[r-a-y]

One of our users reported that pending group topics cannot be viewed on the frontend.

The problem is the topic lookup within a BuddyPress group forum looks against the post name: ​https://github.com/bbpress/bbPress/blob/09313c9984c55429f3e664ca4383768b68ee34b9/src/includes/extend/buddypress/groups.php#L1033. A pending topic does not have a post name, so the lookup fails.

Attached is a patch, which fixes this by changing a pending group topic's slug to 'pending-{$topic_id}' and switches up the logic to query pending group topics by the post ID.

This is related to the other moderation tickets: #3349, #3353.

[r-a-y]

Having more time to think about this, the pending-{$topic_id} slug should be changed to pending--{$topic_id} as I could see a potential conflict where multiple topics may have the topic slug of pending and pending-{x+1} to deal with duplicates.

[r-a-y]

Uses 'pending--{$topic_id}' for pending group topic slugs. Also replaces some hardcoded 'pending' slug instances.

[johnjamesjacoby]

In 7878:

BuddyPress Groups: Restore pending topic access.

Route pending group topics by explicit topic ID while preserving their group forum context. Authors and users who can read pending topics can view and edit them with the normal group templates, while invalid and cross-group topic IDs remain unreadable.

Preserve pending-topic redirects and reply pagination without changing published topic permalinks.

In trunk, for 2.7.

Props r-a-y.
See #3430.

[johnjamesjacoby]

In 7881:

BuddyPress Groups: Restore pending topic access.

Route pending group topics by explicit topic ID while preserving their group forum context. Authors and users who can read pending topics can view and edit them with the normal group templates, while invalid and cross-group topic IDs remain unreadable.

Preserve pending-topic redirects and reply pagination without changing published topic permalinks.

In branches/2.6, for 2.6.20.

Props r-a-y.
Fixes #3430.