Skip to:
Content

bbPress.org

Opened 8 months ago

Closed 7 days ago

#3418 closed enhancement (fixed)

Duplicate topic check should only check for duplicates within a forum

Reported by: r-a-y Owned by: johnjamesjacoby
Milestone: 2.6.7 Priority: normal
Severity: normal Version: 2.0
Component: General - Content Creation Keywords: has-patch commit
Cc:

Description

The duplicate topic check currently checks if a topic is the same across all forums.

We've run into a scenario where there is a forum user who administrates several forums. This user wants to write the same "Introduction" forum topic with the same content for each forum. However, if you're not a super admin, this is not possible.

I would suggest to restrict the duplicate topic check to the specific forum. See attached patch.

Attachments (2)

3418.01.patch (872 bytes) - added by r-a-y 8 months ago.
3418.02.patch (2.5 KB) - added by johnjamesjacoby 7 days ago.

Download all attachments as: .zip

Change History (7)

@r-a-y
8 months ago

#1 @johnjamesjacoby
8 months ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 2.6.7
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

Hey @r-a-y! This seems OK to me.

Any thoughts about adding the same checks to Forums or Replies?

#2 @r-a-y
8 months ago

No need to do the same thing for replies. The duplicate reply check already checks within the existing topic and not across all forum replies.

Up to you regarding forums. Might be useful for huge forums utilizing sub-forums that might want to re-use the same forum name.

#3 @johnjamesjacoby
7 days ago

  • Component changed from Component - Topics to General - Content Creation
  • Keywords commit added; reporter-feedback removed

Adding support for all post types.

#4 @johnjamesjacoby
7 days ago

In 7207:

Content: add post_parent to forum & topic duplicate checks.

This change limits the scope of "duplicate content" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.

This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.

Props r-a-y, johnjamesjacoby.

In trunk, for 2.7.0.

See #3418.

#5 @johnjamesjacoby
7 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7208:

Content: add post_parent to forum & topic duplicate checks.

This change limits the scope of "duplicate content" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.

This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.

Props r-a-y, johnjamesjacoby.

In branches/2.6, for 2.6.7.

Fixes #3418.

Note: See TracTickets for help on using tickets.