Skip to:
Content

bbPress.org

Opened 3 weeks ago

Last modified 3 weeks ago

#3385 assigned defect

"Answer to" (_bbp_reply_to) will not be stored

Reported by: peterkueger Owned by: johnjamesjacoby
Milestone: 2.6.6 Priority: low
Severity: normal Version:
Component: Component - Replies Keywords: needs-patch
Cc:

Description

This is my first report here. I hope, I give you all wanted infomation...

If I click to "ANSWER" to an existing reply (or topic) the answer will not stored into the database.

If I click to that link, I will be forwarded to:
forums/topic/test-topic/page/2/?bbp_reply_to=2002&_wpnonce=2fa94ab9df#new-post
This is a GET request.

After this, the form field "bbp_reply_to" should be filled in
bbpress/includes/common/template.php on line 1757 with this code:

<input type="hidden" name="bbp_reply_to"    id="bbp_reply_to"    value="<?php bbp_form_reply_to(); ?>" />

The function bbp_form_reply_to calls the function bbp_get_form_reply_to in
bbpress/includes/replies/template.php and the result should be generated with this code in line 2496:

		if ( bbp_is_reply_form_post_request() && isset( $_REQUEST['bbp_reply_to'] ) ) {
			$reply_to = bbp_validate_reply_to( $_REQUEST['bbp_reply_to'] );
		}

But this fails, since bbp_is_reply_form_post_request() results with "false", because we're on a GET request.

So the mentioned form field will not be filled and because of this not inserted into the database.

PS
I'm very impressed about bbPress: It's very stable!!!

Change History (3)

#1 follow-up: @johnjamesjacoby
3 weeks ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.6.6
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

Hey @peterkueger, thank you for finding this, and for the kind words about bbPress!

I’ll make sure this gets fixed up in the next minor release. Sorry for the trouble and thank you for the detailed report.

#2 in reply to: ↑ 1 @peterkueger
3 weeks ago

Hey @johnjamesjacoby,

you are greasy! I have to spend so much time to find a bug - and you want to fix them immediately? Seems I have to search further more... ;-)

Thanks a lot!!!

PS
Before I installed bbPress I tried to use wpForo. Until now, I found nearly 100 bugs there. And the developer are not interested to understand them.

#3 @peterkueger
3 weeks ago

Hey @johnjamesjacoby,

the "ANSWER" link of the topic (first reply in the topic) does not set the bbp_reply_to too. There will not be initiated an extra GET request and because of this the hidden input field will not be set.

Did I find a second bug?

Note: See TracTickets for help on using tickets.