Skip to:
Content

Opened 7 months ago

Closed 6 months ago

#3055 closed defect (fixed)

Missing is_single on single replies

Reported by: SergeyBiryukov Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit
Cc:

Description

bbp_template_include_theme_compat() calls bbp_theme_compat_reset_post() for both topics and replies, however 'is_single' => true is only passed to topics.

This leads to missing bbpress, single-reply, reply-edit body classes on reply pages, and potentially other quirks.

Attachments (1)

3055.patch (442 bytes) - added by SergeyBiryukov 7 months ago.

Download all attachments as: .zip

Change History (2)

#1 @johnjamesjacoby
6 months ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6288:

Theme Compat: Add is_ parameters to various query-reset procedures.

This ensures the state of the wp_query global is what someone can safely expect for it to be. It also is used through-out WordPress as a way to auto-assign body classes and various other environmental tweaks.

Fixes #3055. Props sergeybiryukov.

Note: See TracTickets for help on using tickets.