Skip to:
Content

bbPress.org

Opened 3 years ago

Last modified 23 months ago

#2976 new defect

Forum slug settings should be translatable

Reported by: netweb Owned by: johnjamesjacoby
Milestone: 2.6.1 Priority: high
Severity: normal Version:
Component: Locale - i18n/l10n Keywords: needs-patch
Cc: espellcaste@…, jmdodd@…

Description

All of the "default" slugs should be translatable so that a fresh install on a non US English install will include the localised slugs for in each of these sections:

  • Forum Root Slug
  • Single Forum Slugs
  • Forum User Slugs

https://cldup.com/Fad7rLynqR.png

Watch out for bbp_form_slug_conflict_check() checks on each slug when patching this

Change History (10)

#1 follow-up: @espellcaste
3 years ago

  • Cc espellcaste@… added

Maybe related, but allow the settings slug to be changed also would be a good idea.

#2 follow-up: @jmdodd
3 years ago

  • Cc jmdodd@… added

I'm not sure this is something that should be translated given that it directly affects rewrite rule generation. The blog options for category_base and tag_base are filterable but not translatable in WordPress.

#3 @espellcaste
3 years ago

Makes sense!

#4 in reply to: ↑ 2 ; follow-up: @netweb
3 years ago

Replying to jmdodd:

I'm not sure this is something that should be translated given that it directly affects rewrite rule generation. The blog options for category_base and tag_base are filterable but not translatable in WordPress.

They are actually translatable, e.g

#5 in reply to: ↑ 1 @netweb
3 years ago

Replying to espellcaste:

Maybe related, but allow the settings slug to be changed also would be a good idea.

Which slug do you mean?

#6 in reply to: ↑ 4 @ocean90
3 years ago

Replying to netweb:

Replying to jmdodd:

I'm not sure this is something that should be translated given that it directly affects rewrite rule generation. The blog options for category_base and tag_base are filterable but not translatable in WordPress.

They are actually translatable, e.g

category_base/tag_base !== Slug of the "Uncategorized" term.

#8 @johnjamesjacoby
2 years ago

  • Milestone changed from Under Consideration to Awaiting Review
  • Owner set to johnjamesjacoby
  • Priority changed from normal to high

These can be translatable, as defaults, but some of the logic will need to change with how default values are checked.

Let’s do this shortly after 2.6 ships, for a 2.6.1.

#9 @johnjamesjacoby
2 years ago

  • Milestone changed from Awaiting Review to 2.6.1

Moving to 2.6.1.

#10 @netweb
23 months ago

Noting that now that users can change their "user dashboard language" separately from the "site language" any changes here should only ever reflect the "site language" and not any users "user language"

Note: See TracTickets for help on using tickets.