Skip to:
Content

bbPress.org

Opened 3 years ago

Closed 3 years ago

#2968 closed enhancement (fixed)

Accessibility: Bump headings for BuddyPress forums

Reported by: mercime Owned by: johnjamesjacoby
Milestone: 2.6 Priority: high
Severity: normal Version:
Component: Extend - BuddyPress Keywords: has-patch has-screenshots commit
Cc:

Description

Continuing with BP's accessibility improvements, I will be uploading a patch to bump the headings for the group forums and some before and after screenshots for your kind consideration. Thank you.

Attachments (6)

2968.patch (3.0 KB) - added by mercime 3 years ago.
GroupForum.png (46.4 KB) - added by mercime 3 years ago.
GroupForumTopic.png (55.0 KB) - added by mercime 3 years ago.
GroupForumTopicReply.png (53.6 KB) - added by mercime 3 years ago.
GroupCreate.png (33.3 KB) - added by mercime 3 years ago.
GroupManageForums.png (61.6 KB) - added by mercime 3 years ago.

Download all attachments as: .zip

Change History (11)

@mercime
3 years ago

@mercime
3 years ago

@mercime
3 years ago

#1 @espellcaste
3 years ago

@mercime I think I'm lost here... I always thought and learned that h1, h2 h3 was the proper way instead of h1, h2, h2...

Am I wrong or just uniformed? :/

#2 @mercime
3 years ago

@espellcaste Thank you for your question. h1, h2, h3, ... is the heading hierarchy while what we are addressing here is the HTML document outline that organizes specific content/section with the other content of a webpage.

For example in the first image above GroupForum.png, you'll find the following structure in the "Before" screenshot:

h1 - bbPress Testing
-- h2 - Group Admin
----- h3 - Group Forum

The above structure doesn't make sense as the Group Forum content is directly relevant to h1 bbPress Testing as a whole and not related to h2 Group Admin list specifically.

The proposed change below aligns the Group Forum content to the structure it is meant to show in the first place: it's a section that provides supplementary information for h1 bbPress Testing and not the h2 Group Admin list.

h1 - bbPress Testing
-- h2 - Group Admin
-- h2 - Group Forum

#3 @johnjamesjacoby
3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby
  • Priority changed from normal to high

#4 @espellcaste
3 years ago

@mercime Now I get what you are trying to do. Thanks for the feedack.

#5 @netweb
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6202:

Accessibility: Bump headings for BuddyPress group forums.

Props mercime.
Fixes #2968.

Note: See TracTickets for help on using tickets.