Bulk change forum role no longer working

[casiepa]

WP 4.4.1
Selecting 1 or more users, in the dropdown box 'Change forum role to...' choose e.g. participant, click change.
Screen refreshes but nothing is changed.

Reported here: ​https://bbpress.org/forums/topic/how-to-import-bbpress-users/#post-170887
Tested myself and I have the same issue.

[netweb]

I think this is a regression introduced as part of ​#WP22959

To test, I'd take a look at commits from that upstream ticket and see if anything stands out, if the commit is easily reverted in a test setup that might also be a helpful way to test.

[ocean90]

That's because the dropdown exists at the bottom too which replaces the values from the top on submit.

Related: ​#WP35307

[ocean90]

Caused by ​[WP34636] for ​#WP27743.

[ocean90]

WP < 4.6

[ocean90]

WP >= 4.6

[netweb]

Thanks @ocean90, 2906.diff​ merges 2906.patch​ and 2906.2.patch​ around some if/else WordPress 4.6 checks.

Got to watch for this grunt upload_patch:2906 task filenames, it always uses the .diff extension...

[netweb]

In 6061:

General - Administration: Update "change forum role" dropdown

This changeset resolves an issue introduced in WordPress 4.4 ( ​changeset:34636 / ​#WP27743 ) which caused bbPress "change forum role" dropdown to only work using the "bottom" user list table dropdown, for WordPress versions < 4.6 the "change forum role" dropdown is now only shown at the "top" of the user list table.

This changeset also adds a new parameter $which to user_role_bulk_dropdown() which was added in WordPress 4.6 ( ​changeset:37422 / ​#WP35307 ) to pass the location of the extra table nav markup for the "top" or "bottom" "change role" dropdown, and in turn fixes bbPress' "change forum role" dropdown to once again work at the "top" and "bottom" of the user list table.

Props ocean90.
Fixes #2906.

[netweb]

#3045 was marked as a duplicate