Skip to:
Content

Opened 3 years ago

Closed 3 years ago

#2796 closed defect (fixed)

Fix topic template counts tests

Reported by: thebrandonallen Owned by: thebrandonallen
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Tools Keywords: has-patch
Cc:

Description

One too many parameters. Also removed some unnecessary calls to the bbp_get_topic_*_count* calls before the expectedOutputString tests.

Attachments (2)

2796.01.patch (2.7 KB) - added by cnorris23 3 years ago.
2796.2.diff (3.2 KB) - added by netweb 3 years ago.

Download all attachments as: .zip

Change History (6)

@cnorris23
3 years ago

#1 @thebrandonallen
3 years ago

  • Owner set to thebrandonallen

Whoops! Logged in under the wrong name.

#2 @thebrandonallen
3 years ago

Nevermind. They still don't pass. The integer vs. string part is fixed, but the caching in bbp_get_public_child_count is still causing problems. I had forgotten that I had hacked that function to not check the cache when I was testing the patch.

I see two ways to fix this:
1) remove the caching for 2.6, since I'm pretty sure I read somewhere that it's getting an overhaul sometime, and it seems to cause more trouble than it's worth at the moment
2) run our tests by manipulating the post meta directly, rather than through the bbp_update_*_*_count functions

I guess there's always the third option of fixing the caching, but it could hold up 2.6 even longer. Fixing caching just for bbp_get_public_child_count might not be terrible, though.

Last edited 3 years ago by thebrandonallen (previous) (diff)

#3 @netweb
3 years ago

  • Reporter changed from cnorris23 to thebrandonallen

@netweb
3 years ago

#4 @netweb
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5719:

Tests: Remove copy pasta parameters to fix topic count tests

  • Manually flush the cache, our setup/teardown needs more work here.

Props thebrandonallen. Fixes #2796

Note: See TracTickets for help on using tickets.