Opened 10 years ago
Closed 10 years ago
#2796 closed defect (bug) (fixed)
Fix topic template counts tests
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Tools | Keywords: | has-patch |
Cc: |
Description
One too many parameters. Also removed some unnecessary calls to the bbp_get_topic_*_count* calls before the expectedOutputString tests.
Attachments (2)
Change History (6)
#2
@
10 years ago
Nevermind. They still don't pass. The integer vs. string part is fixed, but the caching in bbp_get_public_child_count is still causing problems. I had forgotten that I had hacked that function to not check the cache when I was testing the patch.
I see two ways to fix this:
1) remove the caching for 2.6, since I'm pretty sure I read somewhere that it's getting an overhaul sometime, and it seems to cause more trouble than it's worth at the moment
2) run our tests by manipulating the post meta directly, rather than through the bbp_update_*_*_count functions
I guess there's always the third option of fixing the caching, but it could hold up 2.6 even longer. Fixing caching just for bbp_get_public_child_count might not be terrible, though.
Whoops! Logged in under the wrong name.