restore trashed topic fails

[roysmyth]

Attempting to restore a trashed topic results in the message:

Are you sure you want to do this?
Please try again.

The message repeats upon trying again.

A workaround is to select the topic(s) to restore and use Bulk Action to restore.

This has been reported in the support forum. There is supposed to be a ticket, but I can't find one, hence this ticket.

WP 4.0

[tharsheblows]

Yes, I had this last night too. It works on the front end but not in admin.

Also, for spam replies using the links on the list page, clicking "Approve" changes the status to pending, not published. The "not spam" link works as expected (changes from spam to published). Is this how it is supposed to work?

[tharsheblows]

The addition of the query arg _wp_http_referer was causing the problem, so I took it out. Now it matches how WP core does untrashing of posts.

[tharsheblows]

sorry, everything got jumbled up in the first one. this one should work.

[netweb]

I've just spent another 10 minutes trying to find the other ticket "I thought" existed but cannot find it.

Thanks for the patch @tharsheblows, your patch fixes "replies", the original ticket mentions topics not replies ;)

The fix should be pretty close to the same as you've done for replies above, could you refresh the patch and include both topics and replies please :)

[tharsheblows]

Ha ha ha, oh dear, story of my life. I'll do topics.

[tharsheblows]

And here it is. As always, test it to see what's gone wrong.

[thebrandonallen]

Refresh patch for latest trunk.

Something to consider. This will make all of the other BBP admin links inconsistent with the untrash link, along with being inconsistent with WP's admin links. The redirect doesn't cause the other admin links to fail, but they do cause a change in behavior from admin links for posts and pages.

[thebrandonallen]

Fix untrash admin links for topics/replies

[thebrandonallen]

Removes all redirects on admin links

[tharsheblows]

I think taking off the redirects makes more sense, too. Thanks for updating.

[thebrandonallen]

Attached patch refreshes for trunk and adds escaping to the urls.

[netweb]

Using 2734.6.patch​ topics and replies can no longer be deleted permanently from the trash in the back end, : Error in moving to Trash. (via the front end works), 2734.7.patch​ reverts the delete action for topics and replies to the original code so that topics and replies are still deletable from the trash.

[thebrandonallen]

Adding 2734.8.patch​ to fix 2734.6.patch​, so that it returns a valid "Delete Permanently" link.

[johnjamesjacoby]

In 6263:

Admin: Fix restoring/trashing topics & replies.

Fixes #2734. Props tharsheblows, thebrandonallen, netweb.